Skip to content

[CIR] Upstream CIR codegen for mxcsr x86 builtins #167948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+47 −2
Open

[CIR] Upstream CIR codegen for mxcsr x86 builtins #167948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e76ff90
Upstream CIR codegen for mxcsr x86 builtins
Thibault-Monnier Nov 13, 2025
94b7e33
Merge branch 'main' into cir-mxcsr-codegen
Thibault-Monnier Nov 15, 2025
65ec4ba
Remove duplicate definition
Thibault-Monnier Nov 15, 2025
712fdfd
Apply suggested changes
Thibault-Monnier Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,26 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
case X86::BI__builtin_ia32_vec_set_v16hi:
case X86::BI__builtin_ia32_vec_set_v8si:
case X86::BI__builtin_ia32_vec_set_v4di:
cgm.errorNYI(e->getSourceRange(),
std::string("unimplemented X86 builtin call: ") +
getContext().BuiltinInfo.getName(builtinID));
return {};
case X86::BI_mm_setcsr:
case X86::BI__builtin_ia32_ldmxcsr:
case X86::BI__builtin_ia32_ldmxcsr: {
mlir::Location loc = getLoc(e->getExprLoc());
Address tmp = createMemTemp(e->getArg(0)->getType(), loc);
builder.createStore(loc, ops[0], tmp);
return emitIntrinsicCallOp(*this, e, "x86.sse.ldmxcsr", builder.getVoidTy(),
tmp.getPointer());
}
case X86::BI_mm_getcsr:
case X86::BI__builtin_ia32_stmxcsr:
case X86::BI__builtin_ia32_stmxcsr: {
mlir::Location loc = getLoc(e->getExprLoc());
Address tmp = createMemTemp(e->getType(), loc);
emitIntrinsicCallOp(*this, e, "x86.sse.stmxcsr", builder.getVoidTy(),
tmp.getPointer());
return builder.createLoad(loc, tmp);
}
case X86::BI__builtin_ia32_xsave:
case X86::BI__builtin_ia32_xsave64:
case X86::BI__builtin_ia32_xrstor:
Expand Down
29 changes: 29 additions & 0 deletions clang/test/CIR/CodeGen/X86/sse-builtins.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,35 @@

#include <immintrin.h>

void test_mm_setcsr(unsigned int A) {
// CIR-LABEL: test_mm_setcsr
// CIR: cir.store {{.*}}, {{.*}} : !u32i
// CIR: cir.call_llvm_intrinsic "x86.sse.ldmxcsr" {{.*}} : (!cir.ptr<!u32i>) -> !void

// LLVM-LABEL: test_mm_setcsr
// LLVM: store i32
// LLVM: call void @llvm.x86.sse.ldmxcsr(ptr {{.*}})

// OGCG-LABEL: test_mm_setcsr
// OGCG: store i32
// OGCG: call void @llvm.x86.sse.ldmxcsr(ptr {{.*}})
_mm_setcsr(A);
}

unsigned int test_mm_getcsr(void) {
// CIR-LABEL: test_mm_getcsr
// CIR: cir.call_llvm_intrinsic "x86.sse.stmxcsr" %{{.*}} : (!cir.ptr<!u32i>) -> !void
// CIR: cir.load {{.*}} : !cir.ptr<!u32i>, !u32i

// LLVM-LABEL: test_mm_getcsr
// LLVM: call void @llvm.x86.sse.stmxcsr(ptr %{{.*}})
// LLVM: load i32

// OGCG-LABEL: test_mm_getcsr
// OGCG: call void @llvm.x86.sse.stmxcsr(ptr %{{.*}})
// OGCG: load i32
return _mm_getcsr();
}

void test_mm_sfence(void) {
// CIR-LABEL: test_mm_sfence
Expand Down
Loading