Skip to content

[BOLT][AArch64] Skip as many zeros as possible in padding validation #166467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

[BOLT][AArch64] Skip as many zeros as possible in padding validation #166467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions bolt/lib/Core/BinaryContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,14 +1010,12 @@ bool BinaryContext::hasValidCodePadding(const BinaryFunction &BF) {
return Offset - StartOffset;
};

// Skip a sequence of zero bytes. For AArch64 we only skip 4 bytes of zeros
// in case the following zeros belong to constant island or veneer.
// Skip a sequence of zero bytes. For AArch64 we only skip 4's exact
// multiple number of zeros in case the following zeros belong to veneer.
auto skipZeros = [&]() {
const uint64_t StartOffset = Offset;
uint64_t CurrentOffset = Offset;
for (; CurrentOffset < BF.getMaxSize() &&
(!isAArch64() || CurrentOffset < StartOffset + 4);
++CurrentOffset)
for (; CurrentOffset < BF.getMaxSize(); ++CurrentOffset)
if ((*FunctionData)[CurrentOffset] != 0)
break;

Expand Down
Loading