[CodeGen] Add skipFunction() check to MachineFunctionSplitter #166260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatzeB
requested changes
Nov 3, 2025
| // mfs-split-ehcode flag. | ||
| bool UseProfileData = MF.getFunction().hasProfileData(); | ||
| if (!UseProfileData && !SplitAllEHCode) | ||
| if (!skipFunction(MF.getFunction()) && !UseProfileData && !SplitAllEHCode) |
Contributor
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| if (!skipFunction(MF.getFunction()) && !UseProfileData && !SplitAllEHCode) | |
| if (skipFunction(MF.getFunction()) || (!UseProfileData && !SplitAllEHCode)) |
or am I misreading the logic?
Contributor
There was a problem hiding this comment.
I'd also vote to just put it into a separate if so the pattern looks the same for all the passes...
Member
Author
There was a problem hiding this comment.
You are right. That was a bug.
MatzeB
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MachineFunctionSplitter was missing a skipFunction() check, causing it to incorrectly split functions that should be skipped (e.g., functions with optnone attribute).
This patch adds an early skipFunction() check in runOnMachineFunction() to ensure these functions are never split, regardless of profile data availability or other splitting conditions.