Skip to content

[NFC][TableGen] Adopt CodeGenHelpers in SDNodeInfoEmitter #165622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

[NFC][TableGen] Adopt CodeGenHelpers in SDNodeInfoEmitter #165622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab17e9
[NFC][TableGen[ Adopt CodeGenHelpers in SDNodeInfoEmitter
jurahul Oct 23, 2025
d216e77
Review feedback
jurahul Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/test/TableGen/SDNodeInfoEmitter/no-nodes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def MyTarget : Target;
// CHECK-EMPTY:
// CHECK-NEXT: namespace llvm {
// CHECK-EMPTY:
// CHECK-EMPTY:
// CHECK-NEXT: #ifdef __GNUC__
// CHECK-NEXT: #pragma GCC diagnostic push
// CHECK-NEXT: #pragma GCC diagnostic ignored "-Woverlength-strings"
Expand Down
23 changes: 8 additions & 15 deletions llvm/utils/TableGen/SDNodeInfoEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "Common/CodeGenDAGPatterns.h" // For SDNodeInfo.
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/FormatVariadic.h"
#include "llvm/TableGen/CodeGenHelpers.h"
#include "llvm/TableGen/Error.h"
#include "llvm/TableGen/StringToOffsetTable.h"
#include "llvm/TableGen/TableGenBackend.h"
Expand Down Expand Up @@ -129,9 +130,8 @@ SDNodeInfoEmitter::SDNodeInfoEmitter(const RecordKeeper &RK)
}

void SDNodeInfoEmitter::emitEnum(raw_ostream &OS) const {
OS << "#ifdef GET_SDNODE_ENUM\n";
OS << "#undef GET_SDNODE_ENUM\n\n";
OS << "namespace llvm::" << TargetSDNodeNamespace << " {\n\n";
IfDefEmitter IfDef(OS, "GET_SDNODE_ENUM");
NamespaceEmitter NS(OS, "llvm::" + TargetSDNodeNamespace);

if (!NodesByName.empty()) {
StringRef FirstName = NodesByName.begin()->first;
Expand All @@ -145,14 +145,11 @@ void SDNodeInfoEmitter::emitEnum(raw_ostream &OS) const {

OS << "};\n\n";
OS << "static constexpr unsigned GENERATED_OPCODE_END = " << LastName
<< " + 1;\n\n";
<< " + 1;\n";
} else {
OS << "static constexpr unsigned GENERATED_OPCODE_END = "
"ISD::BUILTIN_OP_END;\n\n";
"ISD::BUILTIN_OP_END;\n";
}

OS << "} // namespace llvm::" << TargetSDNodeNamespace << "\n\n";
OS << "#endif // GET_SDNODE_ENUM\n\n";
}

std::vector<unsigned> SDNodeInfoEmitter::emitNodeNames(raw_ostream &OS) const {
Expand Down Expand Up @@ -324,9 +321,8 @@ static void emitDesc(raw_ostream &OS, StringRef EnumName,
void SDNodeInfoEmitter::emitDescs(raw_ostream &OS) const {
StringRef TargetName = Target.getName();

OS << "#ifdef GET_SDNODE_DESC\n";
OS << "#undef GET_SDNODE_DESC\n\n";
OS << "namespace llvm {\n";
IfDefEmitter IfDef(OS, "GET_SDNODE_DESC");
NamespaceEmitter NS(OS, "llvm");

std::vector<unsigned> NameOffsets = emitNodeNames(OS);
std::vector<std::pair<unsigned, unsigned>> ConstraintOffsetsAndCounts =
Expand All @@ -343,11 +339,8 @@ void SDNodeInfoEmitter::emitDescs(raw_ostream &OS) const {

OS << formatv("static const SDNodeInfo {0}GenSDNodeInfo(\n"
" /*NumOpcodes=*/{1}, {0}SDNodeDescs,\n"
" {0}SDNodeNames, {0}SDTypeConstraints);\n\n",
" {0}SDNodeNames, {0}SDTypeConstraints);\n",
TargetName, NodesByName.size());

OS << "} // namespace llvm\n\n";
OS << "#endif // GET_SDNODE_DESC\n\n";
}

void SDNodeInfoEmitter::run(raw_ostream &OS) const {
Expand Down