Bound ISL operations during pre-vectorization #165204
Conversation
Bound ISL operations during pre-vectorization to prevent indefinite compilation. The MaxOpGuard previously used for schedule computation is now extended to also guard pre-vectorization optimizations. This patch includes a reduced test case derived from the original bug report. Author: Michael Kruse ShikharjQUIC Fixes llvm#132717.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
pls review @Meinersbur @kartcq |
|
Could you add a summary description, it will be used as the template for the commit message |
|
Bound ISL operations during pre-vectorization to Author: Michael Kruse |
Meinersbur
left a comment
Meinersbur
left a comment
There was a problem hiding this comment.
LGTM
Would you like me to land this PR?
Sure.. |
|
@ShikharjQUIC Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
@ShikharjQUIC Could you take a look at #166345? Which seems to be caused by this PR. Thanks! |
|
@Andarwinux Thanks for notifying me. I will look into this asap. |
The problem has been fixed by #166551. |
3 participants
Bound ISL operations during pre-vectorization to
prevent indefinite compilation. The MaxOpGuard
previously used for schedule computation is now
extended to also guard pre-vectorization optimizations.
This patch includes a reduced test case derived
from the original bug report.
Author: Michael Kruse
ShikharjQUIC