Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

Based on some recent discussion in #162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.

Based on some recent discussion in llvm#162007. Documenting this in the best
practices page so we have something easy to point to in code
review/reference for ourselves now that the repository has been cleaned
up.
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@vbvictor
Copy link
Contributor

vbvictor commented Oct 25, 2025

By the way, it seems that CIBestPractices.rst in unreachable via normal link-jumps in the web.
Here it is under "hidden"

CIBestPractices

But it doesn't have a dedicated entry in "Additional topics" to be clickable:

Additional Topics

@boomanaiden154 boomanaiden154 merged commit fd804f0 into llvm:main Oct 25, 2025
12 checks passed
@boomanaiden154 boomanaiden154 deleted the fully-qualified-container-image-names-best-practice branch October 25, 2025 17:06
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Oct 25, 2025
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
…lvm#165067)

Based on some recent discussion in llvm#162007. Documenting this in the best
practices page so we have something easy to point to in code
review/reference for ourselves now that the repository has been cleaned
up.
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
…lvm#165067)

Based on some recent discussion in llvm#162007. Documenting this in the best
practices page so we have something easy to point to in code
review/reference for ourselves now that the repository has been cleaned
up.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
…lvm#165067)

Based on some recent discussion in llvm#162007. Documenting this in the best
practices page so we have something easy to point to in code
review/reference for ourselves now that the repository has been cleaned
up.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants