- 
                Notifications
    You must be signed in to change notification settings 
- Fork 15k
[CI][Github] Add Fully Qualified Container Names to Best Practices #165067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Github] Add Fully Qualified Container Names to Best Practices #165067
Conversation
Based on some recent discussion in llvm#162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
| By the way, it seems that  llvm-project/llvm/docs/Reference.rst Line 19 in 7be3cac 
 But it doesn't have a dedicated entry in "Additional topics" to be clickable: llvm-project/llvm/docs/Reference.rst Line 175 in 7be3cac 
 | 
…lvm#165067) Based on some recent discussion in llvm#162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.
…lvm#165067) Based on some recent discussion in llvm#162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.
…lvm#165067) Based on some recent discussion in llvm#162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.
Based on some recent discussion in #162007. Documenting this in the best practices page so we have something easy to point to in code review/reference for ourselves now that the repository has been cleaned up.