Skip to content

[ThinLTO][WPD] LICM a loop invariant check #164862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

[ThinLTO][WPD] LICM a loop invariant check #164862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,17 +948,17 @@ void llvm::updateVCallVisibilityInIndex(
// linker, as we have no information on their eventual use.
if (DynamicExportSymbols.count(P.first))
continue;
// With validation enabled, we want to exclude symbols visible to regular
// objects. Local symbols will be in this group due to the current
// implementation but those with VCallVisibilityTranslationUnit will have
// already been marked in clang so are unaffected.
if (VisibleToRegularObjSymbols.count(P.first))
continue;
for (auto &S : P.second.getSummaryList()) {
auto *GVar = dyn_cast<GlobalVarSummary>(S.get());
if (!GVar ||
GVar->getVCallVisibility() != GlobalObject::VCallVisibilityPublic)
continue;
// With validation enabled, we want to exclude symbols visible to regular
// objects. Local symbols will be in this group due to the current
// implementation but those with VCallVisibilityTranslationUnit will have
// already been marked in clang so are unaffected.
if (VisibleToRegularObjSymbols.count(P.first))
continue;
GVar->setVCallVisibility(GlobalObject::VCallVisibilityLinkageUnit);
}
}
Expand Down