[clang-doc] fix overlapping navbar #164314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The navbar has a height of 60px, but the sidebar didn't have any top padding so it began underneath the navbar. Now the sidebar has a top padding of 60px.
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) ChangesThe navbar has a height of 60px, but the sidebar didn't have any top Full diff: https://github.com/llvm/llvm-project/pull/164314.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-doc/assets/clang-doc-mustache.css b/clang-tools-extra/clang-doc/assets/clang-doc-mustache.css
index e555ee7c370f7..67f11f77eae61 100644
--- a/clang-tools-extra/clang-doc/assets/clang-doc-mustache.css
+++ b/clang-tools-extra/clang-doc/assets/clang-doc-mustache.css
@@ -396,7 +396,7 @@ body, html {
.sidebar {
width: 250px;
- top: 0;
+ top: 60px;
left: 0;
height: 100%;
position: fixed;
|
Member
Author
|
You can see the changes reflected here: https://erickvelez.com/clang-doc-mustache-output/pr164314/ The "Inner Classes" heading isn't covered by the navbar anymore. Also never noticed that on class pages, the class name is actually displayed on top of the sidebar. |
ilovepi
approved these changes
Oct 21, 2025
Member
Author
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
The navbar has a height of 60px, but the sidebar didn't have any top padding so it began underneath the navbar. Now the sidebar has a top padding of 60px.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
The navbar has a height of 60px, but the sidebar didn't have any top padding so it began underneath the navbar. Now the sidebar has a top padding of 60px.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navbar has a height of 60px, but the sidebar didn't have any top
padding so it began underneath the navbar. Now the sidebar has a top
padding of 60px.