[Clang][NFC] Fix a warning in TransformNestedRequirement #164148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logical or expression should be parenthesized. Fixes llvm#164104
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) ChangesThe logical or expression should be parenthesized. Fixes #164104 Full diff: https://github.com/llvm/llvm-project/pull/164148.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index ca7e3b264cec4..038f39633760d 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -2864,9 +2864,9 @@ TemplateInstantiator::TransformNestedRequirement(
TemplateArgs, Constraint->getSourceRange(), Satisfaction,
/*TopLevelConceptId=*/nullptr, &NewConstraint);
- assert(!Success || !Trap.hasErrorOccurred() &&
- "Substitution failures must be handled "
- "by CheckConstraintSatisfaction.");
+ assert((!Success || !Trap.hasErrorOccurred()) &&
+ "Substitution failures must be handled "
+ "by CheckConstraintSatisfaction.");
}
if (!Success || Satisfaction.HasSubstitutionFailure())
|
zwuis
added
the
skip-precommit-approval
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/22066 Here is the relevant piece of the build log for the reference |
shafik
reviewed
Oct 20, 2025
| assert(!Success || !Trap.hasErrorOccurred() && | ||
| "Substitution failures must be handled " | ||
| "by CheckConstraintSatisfaction."); | ||
| assert((!Success || !Trap.hasErrorOccurred()) && |
Collaborator
There was a problem hiding this comment.
That is really cursed syntax highlighting there.
Collaborator
|
Thank you for the fix. |
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
The logical or expression should be parenthesized. The issue was brought by llvm#161671 Fixes llvm#164104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logical or expression should be parenthesized.
Fixes #164104