Skip to content

Conversation

@Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Oct 17, 2025

Seems like the function returns a dict, not a list of tuples like the other.
Not sure of the schema or the design for this, so fixing the code without using the test-suite name. But this might have to be addressed once the owner can take a look.

@llvmbot llvmbot added the infrastructure Bugs about LLVM infrastructure label Oct 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2025

@llvm/pr-subscribers-infrastructure

Author: Nathan Gauër (Keenuts)

Changes

Seems like the function returns a dict, not a list of tuples like the other.
Not sure of the schema or the design for this, so fixing the code without using the test-suite name. But this might have to be addressed once the owner can take a look.


Full diff: https://github.com/llvm/llvm-project/pull/163944.diff

1 Files Affected:

  • (modified) .ci/premerge_advisor_upload.py (+3-2)
diff --git a/.ci/premerge_advisor_upload.py b/.ci/premerge_advisor_upload.py
index dda4ad24d7ac4..fe3eba90f18d8 100644
--- a/.ci/premerge_advisor_upload.py
+++ b/.ci/premerge_advisor_upload.py
@@ -32,8 +32,9 @@ def main(commit_sha, workflow_run_number, build_log_files):
         "platform": current_platform,
     }
     if test_failures:
-        for name, failure_message in test_failures:
-            failure_info["failures"].append({"name": name, "message": failure_message})
+        for _, failures in test_failures.items():
+            for name, failure_message in failures:
+                failure_info["failures"].append({"name": name, "message": failure_message})
     else:
         ninja_failures = generate_test_report_lib.find_failure_in_ninja_logs(ninja_logs)
         for name, failure_message in ninja_failures:

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

✅ With the latest revision this PR passed the Python code formatter.

Seems like the function returns a dict, not a list of tuples like
the other.
Not sure of the schema or the design for this, so fixing the code
without using the test-suite name. But this might have to be
addressed once the owner can take a look.
@Keenuts Keenuts force-pushed the fix-premerge-upload branch from be3c403 to 95864d7 Compare October 17, 2025 11:29
@Keenuts Keenuts enabled auto-merge (squash) October 17, 2025 11:31
@Keenuts Keenuts disabled auto-merge October 17, 2025 11:49
@Keenuts
Copy link
Contributor Author

Keenuts commented Oct 17, 2025

CI failures now seems unrelated, those are actual LLVM test failures unrelated to this script fix. Merging this now as the script failure could hide actual failures.

@Keenuts Keenuts merged commit 38ce641 into llvm:main Oct 17, 2025
9 of 11 checks passed
@Keenuts Keenuts deleted the fix-premerge-upload branch October 17, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Bugs about LLVM infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants