[acc][flang] Checking scalar like variables when there's storage operand to fir.declare #163439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test? |
@clementval yes, adding rn |
Thanks! |
clementval
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
LGTM. Wait for @razvanlupusoru if he has any comment on this.
| // to the declared memref. | ||
| if (auto storage = op.getStorage()) | ||
| return storage; | ||
| return op.getMemref(); |
There was a problem hiding this comment.
This is not desirable because in FIR, having access to the fir.declare as the "base reference" allows us to get all of the Fortran properties. I would suggest returning varPtr instead.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently this variable
is categorized as a scalar type when it really should be an aggregate type, because it is part of !fir.ref<!fir.array<4xi8>>
This MR adds a classification to capture the storage operand in fir.declare.