-
Notifications
You must be signed in to change notification settings - Fork 15.2k
workflows/release-documentation: Allow secrets pass through from calling workflow #162765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing workflow This sholud fix the part of the workflow that creates a PR with the new documentation.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThis should fix the part of the workflow that creates a PR with the new documentation. Full diff: https://github.com/llvm/llvm-project/pull/162765.diff 2 Files Affected:
diff --git a/.github/workflows/release-documentation.yml b/.github/workflows/release-documentation.yml
index d3d375d3a6df9..4cf973d000a4b 100644
--- a/.github/workflows/release-documentation.yml
+++ b/.github/workflows/release-documentation.yml
@@ -25,6 +25,10 @@ on:
description: 'Upload documentation'
required: false
type: boolean
+ secrets:
+ WWW_RELEASES_TOKEN:
+ description: "Secret used to create a PR with the documentation changes."
+ required: false
jobs:
release-documentation:
diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml
index a184996968cdd..d4c2a55fcc9d7 100644
--- a/.github/workflows/release-tasks.yml
+++ b/.github/workflows/release-tasks.yml
@@ -54,6 +54,9 @@ jobs:
with:
release-version: ${{ needs.validate-tag.outputs.release-version }}
upload: true
+ # Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.
+ secrets:
+ WWW_RELEASES_TOKEN: ${{ secrets.WWW_RELEASES_TOKEN }}
release-doxygen:
name: Build and Upload Release Doxygen
|
c-rhodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you intend to assign the release managers rather than add us as reviewers?
No, I meant to add as reviewers. My mistake. |
|
/cherry-pick 59d4d5c |
|
/pull-request #164538 |
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation. (cherry picked from commit 59d4d5c)
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation.
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation.
This should fix the part of the workflow that creates a PR with the new documentation.