[SelectionDAG] Add SDTCisInt<1> to SDTVecReduce and SDTCisEltOfVec to SDTFPVecReduce. NFC #162761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-selectiondag Author: Craig Topper (topperc) ChangesFull diff: https://github.com/llvm/llvm-project/pull/162761.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Target/TargetSelectionDAG.td b/llvm/include/llvm/Target/TargetSelectionDAG.td
index 7bc90d4428800..5f4f8c391c489 100644
--- a/llvm/include/llvm/Target/TargetSelectionDAG.td
+++ b/llvm/include/llvm/Target/TargetSelectionDAG.td
@@ -300,10 +300,10 @@ def SDTVecInsert : SDTypeProfile<1, 3, [ // vector insert
SDTCisEltOfVec<2, 1>, SDTCisSameAs<0, 1>, SDTCisPtrTy<3>
]>;
def SDTVecReduce : SDTypeProfile<1, 1, [ // vector reduction
- SDTCisInt<0>, SDTCisVec<1>
+ SDTCisInt<0>, SDTCisVec<1>, SDTCisInt<1>
]>;
def SDTFPVecReduce : SDTypeProfile<1, 1, [ // FP vector reduction
- SDTCisFP<0>, SDTCisVec<1>
+ SDTCisFP<0>, SDTCisVec<1>, SDTCisFP<1>
]>;
def SDTVecReverse : SDTypeProfile<1, 1, [ // vector reverse
|
s-barannikov
approved these changes
Oct 10, 2025
| ]>; | ||
| def SDTFPVecReduce : SDTypeProfile<1, 1, [ // FP vector reduction | ||
| SDTCisFP<0>, SDTCisVec<1> | ||
| SDTCisFP<0>, SDTCisVec<1>, SDTCisFP<1> |
Contributor
There was a problem hiding this comment.
Can this be:
Suggested change
| SDTCisFP<0>, SDTCisVec<1>, SDTCisFP<1> | |
| SDTCisEltOfVec<0, 1>, SDTCisVec<1>, SDTCisFP<1> |
Corresponding LLVM intrinsics require the result type to match the source element type, but I don't know if this is still a requirement in SDAG.
Collaborator
Author
There was a problem hiding this comment.
It might be a requirement in SelectionDAG for FP but not int.
topperc
changed the title
DharuniRAcharya
pushed a commit
to DharuniRAcharya/llvm-project
that referenced
this pull request
Oct 13, 2025
… SDTFPVecReduce. NFC (llvm#162761)
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
… SDTFPVecReduce. NFC (llvm#162761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.