Reapply "[Clang][CMake] Use IRPGO instead of FE PGO for Cmake Caches … #160133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm#155957)" This reverts commit 8ed4899. This reapplies the original patch now that the issue in ControlHeightReduction (llvm#159621) has been fixed in llvm#159686.
Member
|
@llvm/pr-subscribers-clang Author: Aiden Grossman (boomanaiden154) Changes…(#155957)" This reverts commit 8ed4899. This reapplies the original patch now that the issue in ControlHeightReduction (#159621) has been fixed in #159686. Full diff: https://github.com/llvm/llvm-project/pull/160133.diff 1 Files Affected:
diff --git a/clang/cmake/caches/PGO.cmake b/clang/cmake/caches/PGO.cmake
index 15bc755d110d1..d6471160037c1 100644
--- a/clang/cmake/caches/PGO.cmake
+++ b/clang/cmake/caches/PGO.cmake
@@ -5,7 +5,7 @@ set(LLVM_ENABLE_PROJECTS "clang;lld" CACHE STRING "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
-set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED ON CACHE BOOL "")
+set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED IR CACHE BOOL "")
set(CLANG_BOOTSTRAP_TARGETS
generate-profdata
stage2
|
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/16293 Here is the relevant piece of the build log for the reference |
boomanaiden154
added a commit
that referenced
this pull request
Sep 23, 2025
… Caches … (#160133)" This reverts commit 6f64b01. This breaks two BOLT buildbots using this cache: 1. https://lab.llvm.org/staging/#/builders/126/builds/2760 2. https://lab.llvm.org/buildbot/#/builders/113/builds/8571 More investigation needed, so reverting for now.
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Sep 25, 2025
This reverts commit 18f7e03. Reapplies llvm#160133. This was reverted originally because it was causing compilation crashes in ControlHeightReduction. It was reverted again because fix in CntrolHeightReduction was causing more problems. Everything should be in working order now, so relanding.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…llvm#160711) This reverts commit 18f7e03. Reapplies llvm#160133. This was reverted originally because it was causing compilation crashes in ControlHeightReduction. It was reverted again because fix in CntrolHeightReduction was causing more problems. Everything should be in working order now, so relanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#155957)"
This reverts commit 8ed4899.
This reapplies the original patch now that the issue in ControlHeightReduction (#159621) has been fixed in #159686.