[lldb] install lldb-tblgen by default to ease cross-compilation (one-liner) #159812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liner) Right now, cross-building `lldb` means either installing a native `lldb-tblgen` by hand (non-trivial, as CMake is painful) or first building all of native clang because of how the CMake rules work, which is not fun. In keeping with the pattern established by llvm-tblgen and clang-tblgen, install lldb-tblgen to ease cross-compilation. Co-authored-by: Ross Burton <[email protected]>
Member
|
@llvm/pr-subscribers-lldb Author: Jonathan Thackray (jthackray) ChangesRight now, cross-building In keeping with the pattern established by llvm-tblgen and clang-tblgen, install lldb-tblgen to ease cross-compilation. Full diff: https://github.com/llvm/llvm-project/pull/159812.diff 1 Files Affected:
diff --git a/lldb/utils/TableGen/CMakeLists.txt b/lldb/utils/TableGen/CMakeLists.txt
index 0ac010bcda355..ce96dddd44201 100644
--- a/lldb/utils/TableGen/CMakeLists.txt
+++ b/lldb/utils/TableGen/CMakeLists.txt
@@ -8,6 +8,7 @@ if (NOT DEFINED LLDB_TABLEGEN_EXE)
set(LLVM_LINK_COMPONENTS Support)
add_tablegen(lldb-tblgen LLDB
+ DESTINATION "${CMAKE_INSTALL_BINDIR}"
LLDBOptionDefEmitter.cpp
LLDBPropertyDefEmitter.cpp
LLDBTableGen.cpp
|
JDevlieghere
approved these changes
Sep 19, 2025
Member
JDevlieghere
left a comment
JDevlieghere
left a comment
There was a problem hiding this comment.
Yup, tablegen makes cross compiling more of a hassle than it could be. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, cross-building
lldbmeans either installing a nativelldb-tblgenby hand (non-trivial, as CMake is painful) or first building all of native clang because of how the CMake rules work, which is not fun.In keeping with the pattern established by llvm-tblgen and clang-tblgen, install lldb-tblgen to ease cross-compilation.