[lldb] Fix build when LLDB_ENABLE_PYTHON is OFF #159665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if Python scripting is disabled, we still need a Python interpreter to build, for example to generate SBLanguages.h or fix up the framework headers.
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesEven if Python scripting is disabled, we still need a Python interpreter to build, for example to generate SBLanguages.h or fix up the framework headers. Full diff: https://github.com/llvm/llvm-project/pull/159665.diff 1 Files Affected:
diff --git a/lldb/cmake/modules/LLDBConfig.cmake b/lldb/cmake/modules/LLDBConfig.cmake
index c65c7e24badd9..90db786a2b6e9 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -187,6 +187,10 @@ if (LLDB_ENABLE_PYTHON)
endif()
option(LLDB_ENABLE_PYTHON_LIMITED_API "Force LLDB to only use the Python Limited API (requires SWIG 4.2 or later)"
${default_enable_python_limited_api})
+else()
+ # Even if Python scripting is disabled, we still need a Python interpreter to
+ # build, for example to generate SBLanguages.h.
+ find_package(Python3 COMPONENTS Interpreter REQUIRED)
endif()
if (LLVM_EXTERNAL_CLANG_SOURCE_DIR)
|
adrian-prantl
approved these changes
Sep 18, 2025
medismailben
approved these changes
Sep 18, 2025
AnthonyLatsis
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 19, 2025
Even if Python scripting is disabled, we still need a Python interpreter to build, for example to generate SBLanguages.h or fix up the framework headers. (cherry picked from commit 1de6f65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if Python scripting is disabled, we still need a Python interpreter to build, for example to generate SBLanguages.h or fix up the framework headers.