[lldb][test] Re-enable TestRerunAndExprDylib.py

[da-viper]

the skipTestIfFn requires a function that return a string to skip or None to run the test. The isUbuntu18_04 function returns a bool and the test is skipped on all platforms.

llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py

Lines 145 to 157 in 25ebdfe

	def wrapper(*args, **kwargs):
	self = args[0]
	if funcutils.requires_self(expected_fn):
	reason = expected_fn(self)
	else:
	reason = expected_fn()
	if reason is not None:
	self.skipTest(reason)
	else:
	return func(*args, **kwargs)
	return wrapper

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

the skipTestIfFn requires a function that return a string to skip or None to run the test. The isUbuntu18_04 function returns a bool and the test is skipped on all platforms.

llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py

Lines 145 to 157 in 25ebdfe

	def wrapper(*args, **kwargs):
	self = args[0]
	if funcutils.requires_self(expected_fn):
	reason = expected_fn(self)
	else:
	reason = expected_fn()
	if reason is not None:
	self.skipTest(reason)
	else:
	return func(*args, **kwargs)
	return wrapper

---

Full diff: https://github.com/llvm/llvm-project/pull/157872.diff

1 Files Affected:

• (modified) lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py (+2-2)

diff --git a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py
index 74e7c895c0fab..a8f98ef0f0182 100644
--- a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py
+++ b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py
@@ -20,9 +20,9 @@ def isUbuntu18_04():
             with open(path) as f:
                 contents = f.read()
             if "Ubuntu 18.04" in contents:
-                return True
+                return "Ubuntu 18.04 is not supported."
 
-    return False
+    return None
 
 
 class TestRerunExprDylib(TestBase):

[slydiman]

The buildbot lldb-remote-linux-ubuntu is broken after this patch. Please fix it ASAP.

[da-viper]

#157916 for now investigating why it breaks on remote