-
Notifications
You must be signed in to change notification settings - Fork 15.2k
CodeGen: Make TargetInstrInfo constructor protected #157336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeGen: Make TargetInstrInfo constructor protected #157336
Conversation
There's no use for the standalone base class TargetRegisterInfo and TargetSubtargetInfo already do this.
s-barannikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/18006 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/14772 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/12214 Here is the relevant piece of the build log for the reference |

There's no use for the standalone base class TargetRegisterInfo
and TargetSubtargetInfo already do this.