[clang-tidy] Fix readability-uppercase-literal-suffix warning with hex literals
#156584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localspook
requested review from
5chmidti,
EugeneZelenko,
HerrCai0907,
PiotrZSL,
carlosgalvezp and
vbvictor
vbvictor
approved these changes
Sep 3, 2025
Contributor
carlosgalvezp
left a comment
carlosgalvezp
left a comment
There was a problem hiding this comment.
LGTM, I wonder why the bB was there in the first place. Binary numbers?
Contributor
Author
|
Because of the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression I introduced in #148275 and was noticed by nettle. The check incorrectly fires on hex literals containing the letter
b(godbolt).(I felt a revert was unnecessary in this case. Maybe others disagree?)