Skip to content

Conversation

@eayus
Copy link
Contributor

@eayus eayus commented Sep 2, 2025

Fix #156346 by marking intrinsics as constexpr. A test has been added for each intrinsic.

The following instrinsics have been modified:

_mm256_zextpd128_pd256
_mm512_zextpd128_pd512
_mm512_zextpd256_pd512
_mm256_zextph128_ph256
_mm512_zextph128_ph512
_mm512_zextph256_ph512
_mm256_zextps128_ps256
_mm512_zextps128_ps512
_mm512_zextps256_ps512
_mm256_zextsi128_si256
_mm512_zextsi128_si512
_mm512_zextsi256_si512

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@eayus
Copy link
Contributor Author

eayus commented Sep 2, 2025

Pinging @RKSimon as I am unable to manually add reviewers.

@RKSimon RKSimon self-requested a review September 2, 2025 11:57
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Developer Policy and LLVM Discourse for more information.

@RKSimon
Copy link
Collaborator

RKSimon commented Sep 2, 2025

@eayus are you able to fix your public github address please?

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - cheers

@eayus
Copy link
Contributor Author

eayus commented Sep 2, 2025

@RKSimon I've changed my account settings to make my email address public, though I'm not sure whether that will retroactively fix the problem?

@RKSimon RKSimon enabled auto-merge (squash) September 2, 2025 13:09
@RKSimon
Copy link
Collaborator

RKSimon commented Sep 2, 2025

@RKSimon I've changed my account settings to make my email address public, though I'm not sure whether that will retroactively fix the problem?

Yes that seems to have worked - auto-merge now reports your proton address. Thanks.

@RKSimon RKSimon merged commit 3ee6170 into llvm:main Sep 2, 2025
9 checks passed
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

@eayus Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Headers][X86] Allow vector zero padding intrinsics to be used in constexpr

2 participants