[clang-shlib] Fix linking libclang-cpp on Haiku #156401
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Brad Smith (brad0) ChangesHaiku requires linking in libnetwork. Full diff: https://github.com/llvm/llvm-project/pull/156401.diff 1 Files Affected:
diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index 945076e1ad810..a4d0aa5779a7e 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -41,6 +41,10 @@ if (CLANG_LINK_CLANG_DYLIB)
set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
endif()
+if (HAIKU)
+ list(APPEND _DEPS network)
+endif()
+
add_clang_library(clang-cpp
SHARED
${INSTALL_WITH_TOOLCHAIN}
|
Haiku requires linking in libnetwork.
brad0
force-pushed
the
haiku_cmake_clang-shlib
branch
from
fd2d05d to
2f560a0
Compare
Contributor
Author
|
@llvm-beanz Ping. |
1 similar comment
Contributor
Author
|
@llvm-beanz Ping. |
Contributor
Author
Collaborator
|
This is required because libclang includes some component that accesses the network I assume. Like some part of clangd? This looks fine to me just want to confirm that it's clearly intentionally needed not some random function we used accidentally. |
Contributor
See haikuports/haikuports#11972 (comment) for involved symbols. |
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
Haiku requires linking in libnetwork. Co-authored-by: Jérôme Duval <[email protected]>
c-rhodes
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 31, 2025
Haiku requires linking in libnetwork. Co-authored-by: Jérôme Duval <[email protected]> (cherry picked from commit 21bcd00)
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
Haiku requires linking in libnetwork. Co-authored-by: Jérôme Duval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haiku requires linking in libnetwork.