Skip to content

[libunwind][test] set fed test to require x86 as others arch may have cross toolchain build #156383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2025
Merged

[libunwind][test] set fed test to require x86 as others arch may have cross toolchain build #156383

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b69df27
switch to llvm-objdump
yingcong-wu Sep 2, 2025
b4a27db
change to unsupported
yingcong-wu Sep 2, 2025
e16146a
add arm
yingcong-wu Sep 2, 2025
fa10485
switch to require x86
yingcong-wu Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libunwind/test/eh_frame_fde_pc_range.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@

// clang-format off

// REQUIRES: linux
// REQUIRES: target={{x86_64-.+-linux-gnu}}
Copy link
Contributor

@fmayer fmayer Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we use llvm-objcopy?

Copy link
Contributor Author

@yingcong-wu yingcong-wu Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good suggestion. I will give it a try later.

// aarch64,arm have a cross toolchain build(llvm-clang-win-x-aarch64, etc)
// where objdump is not available.

// TODO: Figure out why this fails with Memory Sanitizer.
// XFAIL: msan
Expand Down
Loading