[lldb][test] Use lld on Windows in frame format test #156320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link.exe discards DWARF information. Other linkers on non-Windows do not. Uses the same solution as TestFrameFunctionInlined.test. This test was failing with the native PDB plugin but shouldn't have been using PDB anyway (see llvm#114906). Passes with DWARF and lld.
DavidSpickett
requested review from
Michael137 and
Nerixyz
and removed request for
JDevlieghere
Member
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changeslink.exe discards DWARF information. Other linkers on non-Windows do not. Uses the same solution as TestFrameFunctionInlined.test. This test was failing with the native PDB plugin but shouldn't have been using PDB anyway (see #114906). Passes with DWARF and lld. Full diff: https://github.com/llvm/llvm-project/pull/156320.diff 1 Files Affected:
diff --git a/lldb/test/Shell/Settings/TestFrameFormatFunctionReturnObjC.test b/lldb/test/Shell/Settings/TestFrameFormatFunctionReturnObjC.test
index 2692c3d9c3e70..55487235ae8cb 100644
--- a/lldb/test/Shell/Settings/TestFrameFormatFunctionReturnObjC.test
+++ b/lldb/test/Shell/Settings/TestFrameFormatFunctionReturnObjC.test
@@ -2,8 +2,11 @@
# ${function.return-right} in languages that don't implement this frame
# format variable (in this case Objective-C).
#
+# link.exe will discard DWARF information.
+# REQUIRES: (system-windows && lld) || !system-windows
+#
# RUN: split-file %s %t
-# RUN: %clang_host -g -gdwarf %t/main.m -o %t.objc.out
+# RUN: %clang_host -g -gdwarf %t/main.m -o %t.objc.out %if system-windows %{-fuse-ld=lld%}
# RUN: %lldb -x -b -s %t/commands.input %t.objc.out -o exit 2>&1 \
# RUN: | FileCheck %s
|
Collaborator
Author
|
There are for sure more tests that should have this restriction, but I don't think we gain much by going through them all. Just fixing this one because it failed when the native PDB plugin was used. |
Nerixyz
approved these changes
Sep 1, 2025
Contributor
Nerixyz
left a comment
Nerixyz
left a comment
There was a problem hiding this comment.
Test passes for me on x86 with DIA disabled now 👍
Michael137
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link.exe discards DWARF information. Other linkers on non-Windows do not.
Uses the same solution as TestFrameFunctionInlined.test.
This test was failing with the native PDB plugin but shouldn't have been using PDB anyway (see #114906). Passes with DWARF and lld.