[llldb][test] Mark a DWO test unsupported on Darwin and Windows #156306
Conversation
This uses split DWARF and from looking at other tests, it should not be running on Darwin or Windows. It does pass using the DIA PDB plugin but I think this is misleading because it's not actually testing the intended feature. When the native PDB plugin is used it fails because it cannot set a breakpoint. I don't see a point to running this test on Windows at all.
DavidSpickett
requested review from
Michael137 and
Nerixyz
and removed request for
JDevlieghere
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesThis uses split DWARF and from looking at other tests, it should not be running on Darwin or Windows. It does pass using the DIA PDB plugin but I think this is misleading because it's not actually testing the intended feature. When the native PDB plugin is used it fails because it cannot set a breakpoint. I don't see a point to running this test on Windows at all. Full diff: https://github.com/llvm/llvm-project/pull/156306.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/dwo-static-data-member-access.test b/lldb/test/Shell/SymbolFile/DWARF/dwo-static-data-member-access.test
index 6e4deae7b9a0d..40d5e90097eb6 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/dwo-static-data-member-access.test
+++ b/lldb/test/Shell/SymbolFile/DWARF/dwo-static-data-member-access.test
@@ -4,6 +4,9 @@
# a DW_TAG_variable DIE, whose parent DIE is only
# a forward declaration.
+# UNSUPPORTED: system-darwin
+# UNSUPPORTED: system-windows
+
# RUN: %clangxx_host %S/Inputs/dwo-static-data-member.cpp \
# RUN: -g -gdwarf-5 -gsplit-dwarf -flimit-debug-info -o %t
# RUN: %lldb %t -s %s -o exit 2>&1 | FileCheck %s
|
There was a problem hiding this comment.
Agree, that it's better for this to be skipped on Windows.
I think this passed on Windows because Clang always generates a PDB, even if DWARF is used, but I could be wrong. To be able to use DWARF on Windows, this test also missed -fuse-ld=lld - the section names of the produced executable are currently truncated.
Also checked on #154121, and it passes there with the native plugin (the other test, Settings/TestFrameFormatFunctionReturnObjC.test also passes there).
Michael137
left a comment
Michael137
left a comment
There was a problem hiding this comment.
Yea on Darwin the split-dwarf is just ignored. So makes sense that it would pass. But it's not testing what was intended. So skipping it is the right thing to do
4 participants
This uses split DWARF and from looking at other tests, it should not be running on Darwin or Windows.
It does pass using the DIA PDB plugin but I think this is misleading because it's not actually testing the intended feature.
When the native PDB plugin is used it fails because it cannot set a breakpoint. I don't see a point to running this test on Windows at all.
Native PDB plugin test failures are being tracked in #114906.