[flang-rt] Use -Wp to undefine macros #156034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
For me this patch works. Thank you @nikic for creating it. |
Contributor
Author
|
Ping To provide a bit of extra context here, this patch is not needed when the LLVM assertions build sets these macros (using |
Member
|
llvm-project/flang-rt/CMakeLists.txt Line 262 in c09cc2c should be updated to test for -Wp,-U
|
If the macro was previously defined with `-Wp,-D` then a later `-U` is *not* going to take effect, the `-Wp` flag takes precedence. Instead use `-Wp,-U`. This works regardless of whether the original definition was provided via `-D` or `-Wp,-D`.
nikic
force-pushed
the
flang-rt-glibcxx-assertions
branch
from
cb80f64 to
ec8b811
Compare
nikic
force-pushed
the
flang-rt-glibcxx-assertions
branch
from
ec8b811 to
3e34a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the macro was previously defined with
-Wp,-Dthen a later-Uis not going to take effect, the-Wpflag takes precedence.Instead use
-Wp,-U. This works regardless of whether the original definition was provided via-Dor-Wp,-D.Also make sure these flags only get passed to the C++ compiler -- they are only relevant there, and flang does not support
-Wp.