Skip to content

[ADT] Deprecate the redirection from SmallSet to SmallPtrSet #154891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2025
Merged

[ADT] Deprecate the redirection from SmallSet to SmallPtrSet #154891

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f60edd4
[ADT] Deprecate the redirection from SmallSet to SmallPtrSet
kazutakahirata Aug 19, 2025
53a4413
Address a comment.
kazutakahirata Aug 22, 2025
4562f3d
Fix formatting.
kazutakahirata Aug 22, 2025
6fc899e
Address a comment.
kazutakahirata Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion llvm/include/llvm/ADT/SmallSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,28 @@ class SmallSet {
/// If this set is of pointer values, transparently switch over to using
/// SmallPtrSet for performance.
template <typename PointeeType, unsigned N>
class SmallSet<PointeeType*, N> : public SmallPtrSet<PointeeType*, N> {};
class SmallSet<PointeeType *, N> : public SmallPtrSet<PointeeType *, N> {
using Base = SmallPtrSet<PointeeType *, N>;

public:
// LLVM_DEPRECATED placed between "template" and "class" above won't work for
// some reason. Put a deprecation message on constructors instead.
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet() = default;
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet(const SmallSet &) = default;
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet(SmallSet &&) = default;
template <typename IterT>
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet(IterT Begin, IterT End) : Base(Begin, End) {}
template <typename Range>
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet(llvm::from_range_t, Range &&R)
: Base(llvm::from_range, std::move(R)) {}
LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
SmallSet(std::initializer_list<PointeeType *> L) : Base(L) {}
};

/// Equality comparison for SmallSet.
///
Expand Down