Skip to content

Conversation

@kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Aug 21, 2025

Fixes a few test failures on windows. See #153233

@llvmbot
Copy link
Member

llvmbot commented Aug 21, 2025

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/154849.diff

1 Files Affected:

  • (modified) lldb/test/API/commands/settings/TestSettings.py (+2-1)
diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index a7a92442e543f..e85490f4149cc 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1051,6 +1051,7 @@ def test_settings_show_defaults(self):
             substrs=["(default: empty)", '[0]: "PATH"'],
         )
         # dictionaries
+        self.runCmd("settings clear target.env-vars")
         self.expect(
             "settings show --defaults target.env-vars",
             matching=False,
@@ -1070,7 +1071,7 @@ def test_settings_show_defaults(self):
         self.runCmd("settings set target.exec-search-paths /tmp")
         self.expect(
             "settings show --defaults target.exec-search-paths",
-            substrs=["(default: empty)", "[0]: /tmp"],
+            patterns=[r"\(default: empty\)", r"\[0\]: [/\]tmp"],
         )
         # path map
         self.expect(

@kastiglione kastiglione merged commit d4b9aca into llvm:main Aug 21, 2025
9 checks passed
@kastiglione kastiglione deleted the lldb-Fix-TestSettings.py branch August 21, 2025 22:19
@dzhidzhoev
Copy link
Member

The test is still failing on a buildbot https://lab.llvm.org/buildbot/#/builders/197

https://lab.llvm.org/buildbot/#/builders/197/builds/8271

Could you look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants