-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Reland: [OpenMP] Add ompTest library to OpenMP #154786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| ##===----------------------------------------------------------------------===## | ||
| # | ||
| # Build OMPT unit testing library: ompTest | ||
| # | ||
| ##===----------------------------------------------------------------------===## | ||
|
|
||
| cmake_minimum_required(VERSION 3.20) | ||
| project(omptest LANGUAGES CXX) | ||
|
|
||
| option(LIBOMPTEST_BUILD_STANDALONE | ||
| "Build ompTest 'standalone', i.e. w/o GoogleTest." | ||
| ${OPENMP_STANDALONE_BUILD}) | ||
| option(LIBOMPTEST_BUILD_UNITTESTS | ||
| "Build ompTest's unit tests, requires GoogleTest." OFF) | ||
|
|
||
| # In absence of corresponding OMPT support: exit early | ||
| if(NOT ${LIBOMP_OMPT_SUPPORT}) | ||
| return() | ||
| endif() | ||
|
|
||
| include(CMakePackageConfigHelpers) | ||
|
|
||
| set(OMPTEST_HEADERS | ||
| ./include/AssertMacros.h | ||
| ./include/InternalEvent.h | ||
| ./include/InternalEventCommon.h | ||
| ./include/Logging.h | ||
| ./include/OmptAliases.h | ||
| ./include/OmptAsserter.h | ||
| ./include/OmptAssertEvent.h | ||
| ./include/OmptCallbackHandler.h | ||
| ./include/OmptTester.h | ||
| ./include/OmptTesterGlobals.h | ||
| ) | ||
|
|
||
| add_library(omptest | ||
| SHARED | ||
|
|
||
| ${OMPTEST_HEADERS} | ||
| ./src/InternalEvent.cpp | ||
| ./src/InternalEventOperators.cpp | ||
| ./src/Logging.cpp | ||
| ./src/OmptAsserter.cpp | ||
| ./src/OmptAssertEvent.cpp | ||
| ./src/OmptCallbackHandler.cpp | ||
| ./src/OmptTester.cpp | ||
| ) | ||
|
|
||
| # Target: ompTest library | ||
| # On (implicit) request of GoogleTest, link against the one provided with LLVM. | ||
| if ((NOT LIBOMPTEST_BUILD_STANDALONE) OR LIBOMPTEST_BUILD_UNITTESTS) | ||
| # Check if standalone build was requested together with unittests | ||
| if (LIBOMPTEST_BUILD_STANDALONE) | ||
| # Emit warning: this build actually depends on LLVM's GoogleTest | ||
| message(WARNING "LIBOMPTEST_BUILD_STANDALONE and LIBOMPTEST_BUILD_UNITTESTS" | ||
| " requested simultaneously.\n" | ||
| "Linking against LLVM's GoogleTest library archives.\n" | ||
| "Disable LIBOMPTEST_BUILD_UNITTESTS to perform an actual" | ||
| " standalone build.") | ||
| # Explicitly disable LIBOMPTEST_BUILD_STANDALONE | ||
| set(LIBOMPTEST_BUILD_STANDALONE OFF) | ||
| endif() | ||
|
|
||
| # Make sure target llvm_gtest is available | ||
| if (NOT TARGET llvm_gtest) | ||
| message(FATAL_ERROR "Required target not found: llvm_gtest") | ||
| endif() | ||
|
|
||
| # Add llvm_gtest as dependency | ||
| add_dependencies(omptest llvm_gtest) | ||
|
|
||
| # Link llvm_gtest as whole-archive to expose required symbols | ||
| set(GTEST_LINK_CMD "-Wl,--whole-archive" llvm_gtest | ||
| "-Wl,--no-whole-archive" LLVMSupport) | ||
|
|
||
| # Add GoogleTest-based header | ||
| target_sources(omptest PRIVATE ./include/OmptTesterGoogleTest.h) | ||
|
|
||
| # Add LLVM-provided GoogleTest include directories. | ||
| target_include_directories(omptest PRIVATE | ||
| ${LLVM_THIRD_PARTY_DIR}/unittest/googletest/include) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this needed? Shouldn't this be covered on the PUBLIC target_include_directories on llvm_gtest?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I think you're right. AFAICT this can be removed. |
||
|
|
||
| # TODO: Re-visit ABI breaking checks, disable for now. | ||
| target_compile_definitions(omptest PUBLIC | ||
| -DLLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this needed? This looks very fishy.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I had build failures without it, but this seems to depend on how you link |
||
|
|
||
| # Link against gtest and gtest_main | ||
| target_link_libraries(omptest PRIVATE ${GTEST_LINK_CMD}) | ||
| else() | ||
| # Add 'standalone' compile definitions | ||
| target_compile_definitions(omptest PRIVATE | ||
| -DOPENMP_LIBOMPTEST_BUILD_STANDALONE) | ||
|
|
||
| # Add 'standalone' source files | ||
| target_sources(omptest PRIVATE | ||
| ./include/OmptTesterStandalone.h | ||
| ./src/OmptTesterStandalone.cpp) | ||
| endif() | ||
|
|
||
| if(TARGET cxx-headers) | ||
| add_dependencies(omptest cxx-headers) | ||
| endif() | ||
|
|
||
| if(TARGET cxx_shared) | ||
| add_dependencies(omptest cxx_shared) | ||
| endif() | ||
|
|
||
| if(TARGET cxxabi_shared) | ||
| add_dependencies(omptest cxxabi_shared) | ||
| endif() | ||
|
|
||
| # Add common include directories. | ||
| target_include_directories(omptest PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| $<INSTALL_INTERFACE:$<INSTALL_PREFIX>/${LIBOMP_HEADERS_INSTALL_PATH}/omptest> | ||
| ) | ||
|
|
||
| target_compile_features(omptest PRIVATE cxx_std_17) | ||
|
|
||
| # Create and install package configuration files. | ||
| configure_package_config_file( | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/cmake/omptest-config.cmake.in | ||
| ${CMAKE_CURRENT_BINARY_DIR}/cmake/omptest-config.cmake | ||
| INSTALL_DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest" | ||
| ) | ||
|
|
||
| install(FILES ${omptest_BINARY_DIR}/cmake/omptest-config.cmake | ||
| DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest") | ||
|
|
||
| # Install libomptest header files: Copy header-files from include dir | ||
| install(DIRECTORY ./include/ | ||
| DESTINATION "${LIBOMP_HEADERS_INSTALL_PATH}/omptest" | ||
| FILES_MATCHING PATTERN "*.h") | ||
|
|
||
| # Install library and export targets. | ||
| # Note: find_package(omptest) may require setting of PATH_SUFFIXES | ||
| # Example: "lib/cmake/openmp/omptest", this is due to the install location | ||
| install(TARGETS omptest | ||
| EXPORT OPENMPomptest | ||
| LIBRARY COMPONENT omptest | ||
| DESTINATION "${OPENMP_INSTALL_LIBDIR}" | ||
| INCLUDES DESTINATION "${LIBOMP_HEADERS_INSTALL_PATH}/omptest") | ||
|
|
||
| # Allow to link omptest by using: target_link_libraries( ... omptest::omptest) | ||
| # Additionally, it automatically propagates the include directory. | ||
| install(EXPORT OPENMPomptest | ||
| DESTINATION "${OPENMP_INSTALL_LIBDIR}/cmake/openmp/omptest" | ||
| NAMESPACE omptest:: | ||
| FILE omptest-targets.cmake) | ||
|
|
||
| # Discover unit tests (added to check-openmp) | ||
| if(LIBOMPTEST_BUILD_UNITTESTS) | ||
| add_subdirectory(test) | ||
| endif() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need this now that you're using the llvm_gtest target? None of the other places that use llvm_gtest require this. Why does this one?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually "yes", ompTest should be usable like an OMPT-extended version of GoogleTest.
Thus, my goal is pulling in all symbols, but I'm by no means an expert on this matter.
The issue is that without it, there are linker errors when a user-test links against
libomptest.so.That's because of missing symbols, like e.g.
testing::Test::Test()ortesting::internal::GTestLog::~GTestLog().Advice on how to improve this part would be greatly appreciated.
One possibility I saw was to use an intermediate build file, similar to this:
Apart from locating that file properly, I'm not sure which other dependencies this approach would imply (maybe
compiler-rt?).