[Sanitizers][Test] narrower constraint for XFAIL #154245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a followup to llvm#154189 , which broke test on android bot. Making sure XFAIL only happen on darwin bots rdar://158543555
llvmbot
added
compiler-rt
compiler-rt:asan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Mariusz Borsa (wrotki) ChangesIt's a followup to #154189 , rdar://158543555 Full diff: https://github.com/llvm/llvm-project/pull/154245.diff 2 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp b/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
index fc1da56a969df..f12e2b2ada50d 100644
--- a/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
+++ b/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
@@ -16,7 +16,7 @@
// UNSUPPORTED: ios
// Symbolizer fails to find test functions on current macOS bot version
-// XFAIL: target=arm{{.*}}
+// XFAIL: system-darwin && target=arm{{.*}}
#include <CoreFoundation/CoreFoundation.h>
diff --git a/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp b/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
index 5f0be27a36318..c7b9280ea7d8e 100644
--- a/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
@@ -3,7 +3,7 @@
// RUN: not %run %t 1 2>&1 | FileCheck %s --check-prefix=CHECK-FREAD
// Symbolizer fails to find test functions on current macOS bot version
-// XFAIL: target=arm{{.*}}
+// XFAIL: system-darwin && target=arm{{.*}}
#include <stdio.h>
#include <stdlib.h>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a followup to #154189 ,
which broke test on android bot. Making sure XFAIL only happen on darwin
bots
rdar://158543555