[MLIR] Fix SCF verifier crash #153974
Merged
[MLIR] Fix SCF verifier crash #153974
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir-scf Author: Mehdi Amini (joker-eph) ChangesAn operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using Full diff: https://github.com/llvm/llvm-project/pull/153974.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp
index 89731de1df053..fd5b2a8e852da 100644
--- a/mlir/lib/Dialect/SCF/IR/SCF.cpp
+++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp
@@ -4237,13 +4237,15 @@ LogicalResult scf::IndexSwitchOp::verify() {
}
for (auto [idx, result, operand] :
llvm::zip(llvm::seq<unsigned>(0, getNumResults()), getResultTypes(),
- yield.getOperandTypes())) {
- if (result == operand)
+ yield.getOperands())) {
+ if (!operand)
+ return yield.emitOpError() << "operand " << idx << " is null\n";
+ if (result == operand.getType())
continue;
return (emitOpError("expected result #")
<< idx << " of each region to be " << result)
.attachNote(yield.getLoc())
- << name << " returns " << operand << " here";
+ << name << " returns " << operand.getType() << " here";
}
return success();
};
|
Member
|
@llvm/pr-subscribers-mlir Author: Mehdi Amini (joker-eph) ChangesAn operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using Full diff: https://github.com/llvm/llvm-project/pull/153974.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp
index 89731de1df053..fd5b2a8e852da 100644
--- a/mlir/lib/Dialect/SCF/IR/SCF.cpp
+++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp
@@ -4237,13 +4237,15 @@ LogicalResult scf::IndexSwitchOp::verify() {
}
for (auto [idx, result, operand] :
llvm::zip(llvm::seq<unsigned>(0, getNumResults()), getResultTypes(),
- yield.getOperandTypes())) {
- if (result == operand)
+ yield.getOperands())) {
+ if (!operand)
+ return yield.emitOpError() << "operand " << idx << " is null\n";
+ if (result == operand.getType())
continue;
return (emitOpError("expected result #")
<< idx << " of each region to be " << result)
.attachNote(yield.getLoc())
- << name << " returns " << operand << " here";
+ << name << " returns " << operand.getType() << " here";
}
return success();
};
|
Hardcode84
reviewed
Aug 16, 2025
joker-eph
force-pushed
the
verifier_crash
branch
from
dc46b77 to
30770fa
Compare
An operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using `getResultTypes()` will dereference this null Value and crash in the verifier.
joker-eph
force-pushed
the
verifier_crash
branch
from
30770fa to
8b0909a
Compare
Hardcode84
approved these changes
Aug 18, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/9959 Here is the relevant piece of the build log for the reference |
joker-eph
added a commit
to joker-eph/llvm-project
that referenced
this pull request
Aug 20, 2025
An operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using `getResultTypes()` will dereference this null Value and crash in the verifier.
tru
pushed a commit
that referenced
this pull request
Aug 26, 2025
An operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using `getResultTypes()` will dereference this null Value and crash in the verifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An operand of the nested yield op can be null and hasn't been verified yet when processing the enclosing operation. Using
getResultTypes()will dereference this null Value and crash in the verifier.