Skip to content

Conversation

@rampitec
Copy link
Collaborator

This has no impact as the dealloc is now practically disabled.

This has no impact as the dealloc is now practically disabled.
@rampitec rampitec requested a review from shiltian August 15, 2025 17:46
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rampitec rampitec marked this pull request as ready for review August 15, 2025 17:46
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Stanislav Mekhanoshin (rampitec)

Changes

This has no impact as the dealloc is now practically disabled.


Full diff: https://github.com/llvm/llvm-project/pull/153844.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/GCNSubtarget.h (+1-5)
diff --git a/llvm/lib/Target/AMDGPU/GCNSubtarget.h b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
index f9f512bad13ad..2ad83c90dc209 100644
--- a/llvm/lib/Target/AMDGPU/GCNSubtarget.h
+++ b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
@@ -1799,11 +1799,7 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
 
   // \returns true if the subtarget has a hazard requiring an "s_nop 0"
   // instruction before "s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)".
-  bool requiresNopBeforeDeallocVGPRs() const {
-    // Currently all targets that support the dealloc VGPRs message also require
-    // the nop.
-    return true;
-  }
+  bool requiresNopBeforeDeallocVGPRs() const { return !GFX1250Insts; }
 
   bool isDynamicVGPREnabled() const { return DynamicVGPR; }
   unsigned getDynamicVGPRBlockSize() const {

@rampitec rampitec merged commit 5d28284 into main Aug 15, 2025
13 checks passed
@rampitec rampitec deleted the users/rampitec/08-15-_amdgpu_gfx1250_does_not_need_nop_before_vgpr_dealloc branch August 15, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants