[NFCI][msan] Precommit tests for AVX-VNNI #153135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests largely cover AVX-VNNI (Vector Neural Network Instructions): - vpdpbusd, vpdpbusds - vpdpwssd, vpdpwssds AVX-VNNI-INT8: - vpdpbssd, vpdpbssds - vpdpbsud, vpdpbsuds - vpdpbuud, vpdpbuuds AVX-VNNI-INT16: - vpdpwsud, vpdpwsuds - vpdpwusd, vpdpwusds - vpdpwuud, vpdpwuuds These instructions are currently heuristically handled (by OR'ing together the vectors). This is incorrect because: 1) multiplication by a zero should result in an initialized value 2) the addition is horizontal (within vectors, not "vertically" between vectors). Future work can improve the instrumentation by applying the updated handleVectorPmaddIntrinsic() from llvm#152941
|
✅ With the latest revision this PR passed the undef deprecator. |
fmayer
approved these changes
Aug 12, 2025
Contributor
fmayer
left a comment
fmayer
left a comment
There was a problem hiding this comment.
please change title to say "AVX-VNNI" instead of AI
thurstond
changed the title
Contributor
Author
Done per Title Transformation Tuesdays |
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Aug 16, 2025
This extends the pmadd handler (recently improved in llvm#153353) to three-operand intrinsics (multiply-add-accumulate), and applies it to the AVX Vector Neural Network Instructions. Updates the tests from llvm#153135
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 18, 2025
… Neural Network Instructions (VNNI) (#153927) This extends the pmadd handler (recently improved in llvm/llvm-project#153353) to three-operand intrinsics (multiply-add-accumulate), and applies it to the AVX Vector Neural Network Instructions. Updates the tests from llvm/llvm-project#153135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests largely cover AVX-VNNI (Vector Neural Network Instructions):
AVX-VNNI-INT8:
AVX-VNNI-INT16:
These instructions are currently heuristically handled (by OR'ing together the vectors). This is incorrect because:
Future work can improve the instrumentation by applying the updated handleVectorPmaddIntrinsic() from #152941