Skip to content

[SPARC] Change half to use soft promotion rather than PromoteFloat #152727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

[SPARC] Change half to use soft promotion rather than PromoteFloat #152727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/Sparc/SparcISelLowering.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ namespace llvm {

bool useSoftFloat() const override;

bool softPromoteHalfType() const override { return true; }

/// computeKnownBitsForTargetNode - Determine which of the bits specified
/// in Mask are known to be either zero or one and return them in the
/// KnownZero/KnownOne bitsets.
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/Generic/half.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
; RUN: %if powerpc-registered-target %{ llc %s -o - -mtriple=powerpc64le-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,BAD %}
; RUN: %if riscv-registered-target %{ llc %s -o - -mtriple=riscv32-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,CHECK %}
; RUN: %if riscv-registered-target %{ llc %s -o - -mtriple=riscv64-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,CHECK %}
; RUN: %if sparc-registered-target %{ llc %s -o - -mtriple=sparc-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,BAD %}
; RUN: %if sparc-registered-target %{ llc %s -o - -mtriple=sparc64-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,BAD %}
; RUN: %if sparc-registered-target %{ llc %s -o - -mtriple=sparc-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,CHECK %}
; RUN: %if sparc-registered-target %{ llc %s -o - -mtriple=sparc64-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,CHECK %}
; RUN: %if spirv-registered-target %{ llc %s -o - -mtriple=spirv-unknown-unknown | FileCheck %s --check-prefixes=NOCRASH %}
; RUN: %if systemz-registered-target %{ llc %s -o - -mtriple=s390x-unknown-linux-gnu | FileCheck %s --check-prefixes=ALL,CHECK %}
; RUN: %if ve-registered-target %{ llc %s -o - -mtriple=ve-unknown-unknown | FileCheck %s --check-prefixes=ALL,BAD %}
Expand Down
64 changes: 36 additions & 28 deletions llvm/test/CodeGen/SPARC/fp16-promote.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,13 +329,14 @@ define void @test_fadd(ptr %p, ptr %q) nounwind {
; V8-OPT-LABEL: test_fadd:
; V8-OPT: ! %bb.0:
; V8-OPT-NEXT: save %sp, -104, %sp
; V8-OPT-NEXT: lduh [%i0], %i2
; V8-OPT-NEXT: call __extendhfsf2
; V8-OPT-NEXT: lduh [%i0], %o0
; V8-OPT-NEXT: lduh [%i1], %o0
; V8-OPT-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V8-OPT-NEXT: call __extendhfsf2
; V8-OPT-NEXT: lduh [%i1], %o0
; V8-OPT-NEXT: mov %i2, %o0
; V8-OPT-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V8-OPT-NEXT: fadds %f1, %f0, %f0
; V8-OPT-NEXT: fadds %f0, %f1, %f0
; V8-OPT-NEXT: st %f0, [%fp+-4]
; V8-OPT-NEXT: call __truncsfhf2
; V8-OPT-NEXT: ld [%fp+-4], %o0
Expand All @@ -346,13 +347,14 @@ define void @test_fadd(ptr %p, ptr %q) nounwind {
; V8-UNOPT-LABEL: test_fadd:
; V8-UNOPT: ! %bb.0:
; V8-UNOPT-NEXT: save %sp, -104, %sp
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: lduh [%i0], %o0
; V8-UNOPT-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V8-UNOPT-NEXT: lduh [%i0], %i2
; V8-UNOPT-NEXT: st %i2, [%fp+-12] ! 4-byte Folded Spill
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: lduh [%i1], %o0
; V8-UNOPT-NEXT: fmovs %f0, %f1
; V8-UNOPT-NEXT: ld [%fp+-8], %f0 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: ld [%fp+-12], %o0 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: st %f0, [%fp+-8]
; V8-UNOPT-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: fadds %f0, %f1, %f0
; V8-UNOPT-NEXT: st %f0, [%fp+-4]
; V8-UNOPT-NEXT: call __truncsfhf2
Expand All @@ -364,13 +366,14 @@ define void @test_fadd(ptr %p, ptr %q) nounwind {
; V9-LABEL: test_fadd:
; V9: ! %bb.0:
; V9-NEXT: save %sp, -104, %sp
; V9-NEXT: lduh [%i0], %i2
; V9-NEXT: call __extendhfsf2
; V9-NEXT: lduh [%i0], %o0
; V9-NEXT: lduh [%i1], %o0
; V9-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V9-NEXT: call __extendhfsf2
; V9-NEXT: lduh [%i1], %o0
; V9-NEXT: mov %i2, %o0
; V9-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V9-NEXT: fadds %f1, %f0, %f0
; V9-NEXT: fadds %f0, %f1, %f0
; V9-NEXT: st %f0, [%fp+-4]
; V9-NEXT: call __truncsfhf2
; V9-NEXT: ld [%fp+-4], %o0
Expand All @@ -381,14 +384,15 @@ define void @test_fadd(ptr %p, ptr %q) nounwind {
; SPARC64-LABEL: test_fadd:
; SPARC64: ! %bb.0:
; SPARC64-NEXT: save %sp, -192, %sp
; SPARC64-NEXT: lduh [%i0], %i2
; SPARC64-NEXT: call __extendhfsf2
; SPARC64-NEXT: lduh [%i0], %o0
; SPARC64-NEXT: lduh [%i1], %o0
; SPARC64-NEXT: st %f0, [%fp+2043] ! 4-byte Folded Spill
; SPARC64-NEXT: call __extendhfsf2
; SPARC64-NEXT: lduh [%i1], %o0
; SPARC64-NEXT: mov %i2, %o0
; SPARC64-NEXT: ld [%fp+2043], %f1 ! 4-byte Folded Reload
; SPARC64-NEXT: call __truncsfhf2
; SPARC64-NEXT: fadds %f1, %f0, %f1
; SPARC64-NEXT: fadds %f0, %f1, %f1
; SPARC64-NEXT: sth %o0, [%i0]
; SPARC64-NEXT: ret
; SPARC64-NEXT: restore
Expand All @@ -403,13 +407,14 @@ define void @test_fmul(ptr %p, ptr %q) nounwind {
; V8-OPT-LABEL: test_fmul:
; V8-OPT: ! %bb.0:
; V8-OPT-NEXT: save %sp, -104, %sp
; V8-OPT-NEXT: lduh [%i0], %i2
; V8-OPT-NEXT: call __extendhfsf2
; V8-OPT-NEXT: lduh [%i0], %o0
; V8-OPT-NEXT: lduh [%i1], %o0
; V8-OPT-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V8-OPT-NEXT: call __extendhfsf2
; V8-OPT-NEXT: lduh [%i1], %o0
; V8-OPT-NEXT: mov %i2, %o0
; V8-OPT-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V8-OPT-NEXT: fmuls %f1, %f0, %f0
; V8-OPT-NEXT: fmuls %f0, %f1, %f0
; V8-OPT-NEXT: st %f0, [%fp+-4]
; V8-OPT-NEXT: call __truncsfhf2
; V8-OPT-NEXT: ld [%fp+-4], %o0
Expand All @@ -420,13 +425,14 @@ define void @test_fmul(ptr %p, ptr %q) nounwind {
; V8-UNOPT-LABEL: test_fmul:
; V8-UNOPT: ! %bb.0:
; V8-UNOPT-NEXT: save %sp, -104, %sp
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: lduh [%i0], %o0
; V8-UNOPT-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V8-UNOPT-NEXT: lduh [%i0], %i2
; V8-UNOPT-NEXT: st %i2, [%fp+-12] ! 4-byte Folded Spill
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: lduh [%i1], %o0
; V8-UNOPT-NEXT: fmovs %f0, %f1
; V8-UNOPT-NEXT: ld [%fp+-8], %f0 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: ld [%fp+-12], %o0 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: call __extendhfsf2
; V8-UNOPT-NEXT: st %f0, [%fp+-8]
; V8-UNOPT-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V8-UNOPT-NEXT: fmuls %f0, %f1, %f0
; V8-UNOPT-NEXT: st %f0, [%fp+-4]
; V8-UNOPT-NEXT: call __truncsfhf2
Expand All @@ -438,13 +444,14 @@ define void @test_fmul(ptr %p, ptr %q) nounwind {
; V9-LABEL: test_fmul:
; V9: ! %bb.0:
; V9-NEXT: save %sp, -104, %sp
; V9-NEXT: lduh [%i0], %i2
; V9-NEXT: call __extendhfsf2
; V9-NEXT: lduh [%i0], %o0
; V9-NEXT: lduh [%i1], %o0
; V9-NEXT: st %f0, [%fp+-8] ! 4-byte Folded Spill
; V9-NEXT: call __extendhfsf2
; V9-NEXT: lduh [%i1], %o0
; V9-NEXT: mov %i2, %o0
; V9-NEXT: ld [%fp+-8], %f1 ! 4-byte Folded Reload
; V9-NEXT: fmuls %f1, %f0, %f0
; V9-NEXT: fmuls %f0, %f1, %f0
; V9-NEXT: st %f0, [%fp+-4]
; V9-NEXT: call __truncsfhf2
; V9-NEXT: ld [%fp+-4], %o0
Expand All @@ -455,14 +462,15 @@ define void @test_fmul(ptr %p, ptr %q) nounwind {
; SPARC64-LABEL: test_fmul:
; SPARC64: ! %bb.0:
; SPARC64-NEXT: save %sp, -192, %sp
; SPARC64-NEXT: lduh [%i0], %i2
; SPARC64-NEXT: call __extendhfsf2
; SPARC64-NEXT: lduh [%i0], %o0
; SPARC64-NEXT: lduh [%i1], %o0
; SPARC64-NEXT: st %f0, [%fp+2043] ! 4-byte Folded Spill
; SPARC64-NEXT: call __extendhfsf2
; SPARC64-NEXT: lduh [%i1], %o0
; SPARC64-NEXT: mov %i2, %o0
; SPARC64-NEXT: ld [%fp+2043], %f1 ! 4-byte Folded Reload
; SPARC64-NEXT: call __truncsfhf2
; SPARC64-NEXT: fmuls %f1, %f0, %f1
; SPARC64-NEXT: fmuls %f0, %f1, %f1
; SPARC64-NEXT: sth %o0, [%i0]
; SPARC64-NEXT: ret
; SPARC64-NEXT: restore
Expand Down
Loading