[clang][x86] Add C/C++ and 32/64-bit test coverage to constexpr tests #152478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Pedro Lobo (pedroclobo) ChangesThe previous test incorrectly assumed 32-bit integers, leading to incorrect bit counts. This change updates the test result to assume 64-bit integers. Full diff: https://github.com/llvm/llvm-project/pull/152478.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c b/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
index ca8f5e482cc56..f4de0f17caacf 100644
--- a/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
+++ b/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
@@ -8,7 +8,7 @@ __m512i test_mm512_popcnt_epi64(__m512i __A) {
// CHECK: @llvm.ctpop.v8i64
return _mm512_popcnt_epi64(__A);
}
-TEST_CONSTEXPR(match_v8di(_mm512_popcnt_epi64((__m512i)(__v8di){+5, -3, -10, +8, 0, -256, +256, -128}), 2, 31, 30, 1, 0, 24, 1, 25));
+TEST_CONSTEXPR(match_v8di(_mm512_popcnt_epi64((__m512i)(__v8di){+5, -3, -10, +8, 0, -256, +256, -128}), 2, 63, 62, 1, 0, 56, 1, 57));
__m512i test_mm512_mask_popcnt_epi64(__m512i __W, __mmask8 __U, __m512i __A) {
// CHECK-LABEL: @test_mm512_mask_popcnt_epi64
|
Member
|
@llvm/pr-subscribers-backend-x86 Author: Pedro Lobo (pedroclobo) ChangesThe previous test incorrectly assumed 32-bit integers, leading to incorrect bit counts. This change updates the test result to assume 64-bit integers. Full diff: https://github.com/llvm/llvm-project/pull/152478.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c b/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
index ca8f5e482cc56..f4de0f17caacf 100644
--- a/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
+++ b/clang/test/CodeGen/X86/avx512vpopcntdq-builtins.c
@@ -8,7 +8,7 @@ __m512i test_mm512_popcnt_epi64(__m512i __A) {
// CHECK: @llvm.ctpop.v8i64
return _mm512_popcnt_epi64(__A);
}
-TEST_CONSTEXPR(match_v8di(_mm512_popcnt_epi64((__m512i)(__v8di){+5, -3, -10, +8, 0, -256, +256, -128}), 2, 31, 30, 1, 0, 24, 1, 25));
+TEST_CONSTEXPR(match_v8di(_mm512_popcnt_epi64((__m512i)(__v8di){+5, -3, -10, +8, 0, -256, +256, -128}), 2, 63, 62, 1, 0, 56, 1, 57));
__m512i test_mm512_mask_popcnt_epi64(__m512i __W, __mmask8 __U, __m512i __A) {
// CHECK-LABEL: @test_mm512_mask_popcnt_epi64
|
RKSimon
reviewed
Aug 7, 2025
Collaborator
RKSimon
left a comment
RKSimon
left a comment
There was a problem hiding this comment.
nice catch - any idea why the test was passing?
Member
Author
I don't really know how to run/verify these I've been relying on my editor's LSP. It flagged the failing |
Collaborator
|
just realised its not being run as c++ - just plain c :( Please can you add additional RUN lines? |
Collaborator
|
avx512vpopcntdqvl-builtins.c needs additional RUN lines as well |
RKSimon
added a commit
that referenced
this pull request
Aug 7, 2025
Member
Author
|
Oh, I see you added the run lines in |
Some files containing `constexpr` tests did not have a C++ run line.
pedroclobo
force-pushed
the
x86-constexpr-fix-test
branch
from
1ad935a to
5d3a3ec
Compare
pedroclobo
changed the title
_mm512_popcnt_epi64 constexpr test
Collaborator
|
(PR title + summary needs a little work) |
pedroclobo
changed the title
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/24875 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing C++ run lines to test files containing
constexprtests.Also adds missing 32/64-bit test coverage to the following tests:
clang/test/CodeGen/X86/avx512-reduceIntrin.cclang/test/CodeGen/X86/avx512-reduceMinMaxIntrin.cclang/test/CodeGen/X86/avx512vpopcntdq-builtins.cclang/test/CodeGen/X86/avx512vpopcntdqvl-builtins.cAdditionally, fixes a
_mm512_popcnt_epi64constexprtest that incorrectly assumed 32-bit integers, leading to incorrect bit counts. This change updates the test result to assume 64-bit integers.