-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Remove reference to reverted PR #130742 #152242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to reverted PR #130742 #152242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may take several years to remove this pattern from downstream projects... So I don't know when to reland this patch.
LGTM. But it should be folded into main. Then we can backport it to 21.x.
The release notes on |
@llvm/pr-subscribers-clang Author: Hubert Tong (hubert-reinterpretcast) ChangesBased on the file history in https://github.com/dtcxzyw/llvm-project/commits/main/llvm/test/CodeGen/AMDGPU/memcpy-crash-issue63986.ll, it appears #130742 was reverted by #138168 and never re-applied. Full diff: https://github.com/llvm/llvm-project/pull/152242.diff 1 Files Affected:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 1c6e7fc1c0760..f4f7dd8342d92 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -55,7 +55,7 @@ C/C++ Language Potentially Breaking Changes
case for old-style offsetof idioms like ``((int)(&(((struct S *)0)->field)))``, to
ensure they are not caught by these optimizations. It is also possible to use
``-fwrapv-pointer`` or ``-fno-delete-null-pointer-checks`` to make pointer arithmetic
- on null pointers well-defined. (#GH130734, #GH130742, #GH130952)
+ on null pointers well-defined. (#GH130734, #GH130952)
C++ Specific Potentially Breaking Changes
-----------------------------------------
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main does not have this issue (as this only affects 21, not 22)
LGTM, Thanks!
Based on the file history in https://github.com/dtcxzyw/llvm-project/commits/main/llvm/test/CodeGen/AMDGPU/memcpy-crash-issue63986.ll, it appears #130742 was reverted by #138168 and never re-applied.
8a80926
to
6203dde
Compare
Based on the file history in https://github.com/dtcxzyw/llvm-project/commits/main/llvm/test/CodeGen/AMDGPU/memcpy-crash-issue63986.ll, it appears #130742 was reverted by #138168 and never re-applied.