Skip to content

Conversation

hubert-reinterpretcast
Copy link
Collaborator

Copy link
Member

@dtcxzyw dtcxzyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may take several years to remove this pattern from downstream projects... So I don't know when to reland this patch.

LGTM. But it should be folded into main. Then we can backport it to 21.x.

@hubert-reinterpretcast
Copy link
Collaborator Author

The release notes on main are now for the next release: 3d8db8e

@hubert-reinterpretcast hubert-reinterpretcast marked this pull request as ready for review August 6, 2025 15:07
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 6, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 6, 2025

@llvm/pr-subscribers-clang

Author: Hubert Tong (hubert-reinterpretcast)

Changes

Based on the file history in https://github.com/dtcxzyw/llvm-project/commits/main/llvm/test/CodeGen/AMDGPU/memcpy-crash-issue63986.ll, it appears #130742 was reverted by #138168 and never re-applied.


Full diff: https://github.com/llvm/llvm-project/pull/152242.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+1-1)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 1c6e7fc1c0760..f4f7dd8342d92 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -55,7 +55,7 @@ C/C++ Language Potentially Breaking Changes
   case for old-style offsetof idioms like ``((int)(&(((struct S *)0)->field)))``, to
   ensure they are not caught by these optimizations.  It is also possible to use
   ``-fwrapv-pointer`` or   ``-fno-delete-null-pointer-checks`` to make pointer arithmetic
-  on null pointers well-defined. (#GH130734, #GH130742, #GH130952)
+  on null pointers well-defined. (#GH130734, #GH130952)
 
 C++ Specific Potentially Breaking Changes
 -----------------------------------------

Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main does not have this issue (as this only affects 21, not 22)
LGTM, Thanks!

@cor3ntin
Copy link
Contributor

cor3ntin commented Aug 6, 2025

@tru

@tru tru moved this from Needs Triage to Needs Merge in LLVM Release Status Aug 8, 2025
@tru tru force-pushed the users/hubert-reinterpretcast/clang21-releaseNotesFixForRevertedPR130742 branch from 8a80926 to 6203dde Compare August 8, 2025 10:12
@tru tru merged commit 6203dde into release/21.x Aug 8, 2025
0 of 2 checks passed
@tru tru deleted the users/hubert-reinterpretcast/clang21-releaseNotesFixForRevertedPR130742 branch August 8, 2025 10:12
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category release:backport

Projects

Development

Successfully merging this pull request may close these issues.

5 participants