[llvm-reduce] Do not convert lifetime operand to argument #151694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifetime argument is now required to be an alloca, so do not try to convert it to a function argument. The reduction is now going to leave behind an unused alloca with lifetime markers, which should be cleaned up separately.
arsenm
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lifetime argument is now required to be an alloca, so do not try to convert it to a function argument.
The reduction is now going to leave behind an unused alloca with lifetime markers, which should be cleaned up separately.
I'd say this fixes #93713. It doesn't remove the lifetime markers as the issue suggests, but at least they're now not going to be on the argument.