Skip to content

[llvm][utils] Improve the StringRef summary formatter #151594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

[llvm][utils] Improve the StringRef summary formatter #151594

merged 1 commit into from
Aug 21, 2025

Conversation

@kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Jul 31, 2025 •
edited
Loading

Improve the StringRef summary formatter in the following ways:

  • inherit adherence to the target.max-string-summary-length setting
  • support non-printable bytes (such as null bytes, and any other binary data)

With the previous implementation, some non-printable bytes would raise a Python exception.

@kastiglione kastiglione requested a review from jimingham July 31, 2025 21:18
jimingham
jimingham approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@jimingham jimingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kastiglione kastiglione merged commit 933d872 into llvm:main Aug 21, 2025
10 checks passed
@kastiglione kastiglione deleted the llvm-utils-Improve-the-StringRef-summary-formatter branch August 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimingham jimingham jimingham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kastiglione @jimingham