Skip to content

Conversation

@cjappl
Copy link
Contributor

@cjappl cjappl commented Jul 26, 2025

Related to #150776 and #146120

Disable to fix test runner:
https://lab.llvm.org/buildbot/#/builders/208/builds/3123

@cjappl cjappl merged commit 26808ef into llvm:main Jul 26, 2025
9 of 12 checks passed
@llvmbot
Copy link
Member

llvmbot commented Jul 26, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Chris Apple (cjappl)

Changes

Related to #150776 and #146120

Disable to fix test runner:
https://lab.llvm.org/buildbot/#/builders/208/builds/3123


Full diff: https://github.com/llvm/llvm-project/pull/150807.diff

1 Files Affected:

  • (modified) compiler-rt/test/rtsan/pthread_cond_wait.cpp (+7-5)
diff --git a/compiler-rt/test/rtsan/pthread_cond_wait.cpp b/compiler-rt/test/rtsan/pthread_cond_wait.cpp
index 915ec07228554..29afbf4b060cc 100644
--- a/compiler-rt/test/rtsan/pthread_cond_wait.cpp
+++ b/compiler-rt/test/rtsan/pthread_cond_wait.cpp
@@ -15,6 +15,10 @@
 
 int main() {
   std::cout << "Entry to main!" << std::endl;
+
+
+  // TODO: This is disabled because it does cause a test failure
+  /*
   std::mutex mut;
   std::condition_variable cv;
   bool go{false};
@@ -33,11 +37,9 @@ int main() {
   // cv.wait(lock, [&] { return go; });
   // but timed wait could segfault
 
-  // NOTE: If this test segfaults on a test runner, please comment
-  //       out this line and submit the patch.
-  //       I will follow up with a fix of the underlying problem,
-  //       but first I need to understand if it fails a test runner
-  cv.wait_for(lock, std::chrono::milliseconds(200), [&] { return go; });
+  // NOTE: When a fix for the pthread_cond issue #146120 is fixed, uncomment this line
+  //cv.wait_for(lock, std::chrono::milliseconds(200), [&] { return go; });
+  */
 
   std::cout << "Exit from main!" << std::endl;
 }

@github-actions
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- compiler-rt/test/rtsan/pthread_cond_wait.cpp
View the diff from clang-format here.
diff --git a/compiler-rt/test/rtsan/pthread_cond_wait.cpp b/compiler-rt/test/rtsan/pthread_cond_wait.cpp
index 29afbf4b0..473c95999 100644
--- a/compiler-rt/test/rtsan/pthread_cond_wait.cpp
+++ b/compiler-rt/test/rtsan/pthread_cond_wait.cpp
@@ -16,7 +16,6 @@
 int main() {
   std::cout << "Entry to main!" << std::endl;
 
-
   // TODO: This is disabled because it does cause a test failure
   /*
   std::mutex mut;

mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants