Skip to content

Conversation

@callumfare
Copy link
Contributor

Fix the olWaitEvents tests after #150217 broke them

@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2025

@llvm/pr-subscribers-offload

Author: Callum Fare (callumfare)

Changes

Fix the olWaitEvents tests after #150217 broke them


Full diff: https://github.com/llvm/llvm-project/pull/150465.diff

1 Files Affected:

  • (modified) offload/unittests/OffloadAPI/queue/olWaitEvents.cpp (+6-3)
diff --git a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
index c1e9acd1797d8..9838562752cc4 100644
--- a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
+++ b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
@@ -52,7 +52,8 @@ TEST_P(olWaitEventsTest, Success) {
       ASSERT_SUCCESS(olWaitEvents(Queues[I], &Events[I - 1], 1));
 
     ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
-                                  sizeof(Args), &LaunchArgs, &Events[I]));
+                                  sizeof(Args), &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -85,7 +86,8 @@ TEST_P(olWaitEventsTest, SuccessSingleQueue) {
       ASSERT_SUCCESS(olWaitEvents(Queue, &Events[I - 1], 1));
 
     ASSERT_SUCCESS(olLaunchKernel(Queue, Device, Kernel, &Args, sizeof(Args),
-                                  &LaunchArgs, &Events[I]));
+                                  &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queue, &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -118,7 +120,8 @@ TEST_P(olWaitEventsTest, SuccessMultipleEvents) {
       ASSERT_SUCCESS(olWaitEvents(Queues[I], Events, I));
 
     ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
-                                  sizeof(Args), &LaunchArgs, &Events[I]));
+                                  sizeof(Args), &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));

@callumfare callumfare merged commit 78faf99 into llvm:main Jul 24, 2025
11 checks passed
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants