[Offload] Add check-offload-unit to check-offload #150230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-offload Author: Kenneth Benzie (Benie) (kbenzie) ChangesFull diff: https://github.com/llvm/llvm-project/pull/150230.diff 1 Files Affected:
diff --git a/offload/test/CMakeLists.txt b/offload/test/CMakeLists.txt
index 711621de9075d..90171f6a398d8 100644
--- a/offload/test/CMakeLists.txt
+++ b/offload/test/CMakeLists.txt
@@ -75,3 +75,5 @@ add_lit_testsuite(check-offload-unit "Running offload unittest suites"
${CMAKE_CURRENT_BINARY_DIR}/unit
EXCLUDE_FROM_CHECK_ALL
DEPENDS LLVMOffload OffloadUnitTests)
+
+add_dependencies(check-offload check-offload-unit)
|
RossBrunton
reviewed
Jul 23, 2025
| @@ -75,3 +75,5 @@ add_lit_testsuite(check-offload-unit "Running offload unittest suites" | |||
| ${CMAKE_CURRENT_BINARY_DIR}/unit | |||
| EXCLUDE_FROM_CHECK_ALL | |||
| DEPENDS LLVMOffload OffloadUnitTests) | |||
|
|
|||
| add_dependencies(check-offload check-offload-unit) | |||
There was a problem hiding this comment.
This has the annoying side effect of making it so that the offload API tests are ran and then the "main" openmp tests. This means we don't get a single progress bar and failure list.
There was a problem hiding this comment.
This works properly for the other projects, like check-clang and check-clang-unit. I don't know offhand what they do but you should be able to read about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.