Skip to content

Revert "[GVN][NFC] Use early return in phiTranslateImpl() (#149268)" #149270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Revert "[GVN][NFC] Use early return in phiTranslateImpl() (#149268)" #149270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions llvm/lib/Transforms/Scalar/GVN.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2367,15 +2367,12 @@ uint32_t GVNPass::ValueTable::phiTranslateImpl(const BasicBlock *Pred,
// See if we can refine the value number by looking at the PN incoming value
// for the given predecessor.
if (PHINode *PN = NumberingPhi[Num]) {
if (PN->getParent() != PhiBlock)
return Num;

for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I) {
if (PN->getIncomingBlock(I) != Pred)
continue;
if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))
return TransVal;
}
if (PN->getParent() == PhiBlock)
for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I)
if (PN->getIncomingBlock(I) == Pred)
if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))
return TransVal;
return Num;
}

if (BasicBlock *BB = NumberingBB[Num]) {
Expand Down
Loading