Skip to content

Revert "[Support] Error if SocketPath is too long" #149096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Revert "[Support] Error if SocketPath is too long" #149096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions llvm/lib/Support/raw_socket_stream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,6 @@ ListeningSocket::ListeningSocket(ListeningSocket &&LS)
Expected<ListeningSocket> ListeningSocket::createUnix(StringRef SocketPath,
int MaxBacklog) {

// If SocketPath is too long, the path will be truncated, and there may be
// collisions with other truncated addresses that the fs::exists check below
// will be unable to detect.
if (SocketPath.size() >= sizeof(sockaddr_un::sun_path))
return llvm::make_error<StringError>(
std::make_error_code(std::errc::filename_too_long),
"SocketPath too long");

// Handle instances where the target socket address already exists and
// differentiate between a preexisting file with and without a bound socket
//
Expand Down
Loading