[llvm][cmake] Add clang if not already present when building lldb #149055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes llvm#54555 We could do what flang does and enable clang automatically, but I personally prefer making the user make the choice. Also from a buld requirements perspective, flang is a bigger build than clang. So if you're already set on building flang, clang should be within your budget too. lldb is smaller than clang.
|
As suggested by @labath #54555 (comment). |
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesFixes #54555 We could do what flang does and enable clang automatically, but I personally prefer making the user make the choice. Also from a buld requirements perspective, flang is a bigger build than clang. So if you're already set on building flang, clang should be within your budget too. lldb is smaller than clang. Full diff: https://github.com/llvm/llvm-project/pull/149055.diff 1 Files Affected:
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 3f8201fa426fe..bf52533abe525 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -179,6 +179,12 @@ if ("flang" IN_LIST LLVM_ENABLE_PROJECTS)
endif ()
endif()
+if ("lldb" IN_LIST LLVM_ENABLE_PROJECTS)
+ if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS)
+ message(FATAL_ERROR "Clang is not enabled, but is required for lldb.")
+ endif ()
+endif ()
+
if ("libc" IN_LIST LLVM_ENABLE_PROJECTS)
message(WARNING "Using LLVM_ENABLE_PROJECTS=libc is deprecated. Please use "
"-DLLVM_ENABLE_RUNTIMES=libc or see the instructions at "
|
|
You might wonder what a standalone build does when clang isn't in the base build, I also wonder this because I have not been able to get it to build at all :) So I might do a follow up for standalone if I can work around the problems. |
I would prefer that too, but I think there's also value in consistency. Unless you're really set on this, I think we should do what flang does. |
DavidSpickett
changed the title
|
I've done it the flang way. |
User error on my part, it works fine and because it uses CMake's config mechanism to find clang it does fail in a reasonable way. |
JDevlieghere
approved these changes
Jul 16, 2025
|
I think that's right. I will double check that this doesn't make the "standalone" lldb in fact build clang as well. |
|
I'm okay with merging this and keeping an eye on https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/ which covers all the standalone scenarios we officially support. |
It does not. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/19135 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/6231 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/38425 Here is the relevant piece of the build log for the reference |
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54555
This follows flang's pattern, it adds clang if you don't have it in LLVM_ENABLE_PROJECTS.