Skip to content

[libc][math] Refactor ldexpf implementation to header-only in src/__support/math folder #147906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/shared/math.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"
#include "math/ldexpf.h"
#include "math/ldexpf128.h"
#include "math/ldexpf16.h"

Expand Down
23 changes: 23 additions & 0 deletions libc/shared/math/ldexpf.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
//===-- Shared ldexpf function ----------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIBC_SHARED_MATH_LDEXPF_H
#define LLVM_LIBC_SHARED_MATH_LDEXPF_H

#include "shared/libc_common.h"
#include "src/__support/math/ldexpf.h"

namespace LIBC_NAMESPACE_DECL {
namespace shared {

using math::ldexpf;

} // namespace shared
} // namespace LIBC_NAMESPACE_DECL

#endif // LLVM_LIBC_SHARED_MATH_LDEXPF_H
8 changes: 8 additions & 0 deletions libc/src/__support/math/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,11 @@ add_header_library(
libc.src.__support.FPUtil.manipulation_functions
libc.include.llvm-libc-macros.float16_macros
)

add_header_library(
ldexpf
HDRS
ldexpf.h
DEPENDS
libc.src.__support.FPUtil.manipulation_functions
)
28 changes: 28 additions & 0 deletions libc/src/__support/math/ldexpf.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
//===-- Implementation header for ldexpf ------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H

#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"

namespace LIBC_NAMESPACE_DECL {

namespace math {

static constexpr float ldexpf(float x, int exp) {
return fputil::ldexp(x, exp);
}

} // namespace math

} // namespace LIBC_NAMESPACE_DECL

#endif // LLVM_LIBC_SRC___SUPPORT_MATH_LDEXPF_H
2 changes: 1 addition & 1 deletion libc/src/math/generic/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1913,7 +1913,7 @@ add_entrypoint_object(
HDRS
../ldexpf.h
DEPENDS
libc.src.__support.FPUtil.manipulation_functions
libc.src.__support.math.ldexpf
)

add_entrypoint_object(
Expand Down
6 changes: 2 additions & 4 deletions libc/src/math/generic/ldexpf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@
//===----------------------------------------------------------------------===//

#include "src/math/ldexpf.h"
#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
#include "src/__support/math/ldexpf.h"

namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(float, ldexpf, (float x, int exp)) {
return fputil::ldexp(x, exp);
return math::ldexpf(x, exp);
}

} // namespace LIBC_NAMESPACE_DECL
15 changes: 14 additions & 1 deletion utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2197,6 +2197,14 @@ libc_support_library(
],
)

libc_support_library(
name = "__support_math_ldexpf",
hdrs = ["src/__support/math/ldexpf.h"],
deps = [
":__support_fputil_manipulation_functions",
],
)

############################### complex targets ################################

libc_function(
Expand Down Expand Up @@ -3346,7 +3354,12 @@ libc_math_function(name = "ilogbf16")

libc_math_function(name = "ldexp")

libc_math_function(name = "ldexpf")
libc_math_function(
name = "ldexpf",
additional_deps = [
":__support_math_ldexpf",
]
)

libc_math_function(name = "ldexpl")

Expand Down
Loading