Skip to content

[libc][math] Refactor frexpf16 implementation to header-only in src/__support/math folder. #147889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/shared/math.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
#include "math/expf.h"
#include "math/expf16.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"

#endif // LLVM_LIBC_SHARED_MATH_H
29 changes: 29 additions & 0 deletions libc/shared/math/frexpf16.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//===-- Shared frexpf16 function --------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIBC_SHARED_MATH_FREXPF16_H
#define LLVM_LIBC_SHARED_MATH_FREXPF16_H

#include "include/llvm-libc-macros/float16-macros.h"
#include "shared/libc_common.h"

#ifdef LIBC_TYPES_HAS_FLOAT16

#include "src/__support/math/frexpf16.h"

namespace LIBC_NAMESPACE_DECL {
namespace shared {

using math::frexpf16;

} // namespace shared
} // namespace LIBC_NAMESPACE_DECL

#endif // LIBC_TYPES_HAS_FLOAT16

#endif // LLVM_LIBC_SHARED_MATH_FREXPF16_H
10 changes: 10 additions & 0 deletions libc/src/__support/math/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,13 @@ add_header_library(
libc.src.__support.macros.properties.types
libc.src.__support.FPUtil.manipulation_functions
)

add_header_library(
frexpf16
HDRS
frexpf16.h
DEPENDS
libc.src.__support.macros.config
libc.src.__support.macros.properties.types
libc.src.__support.FPUtil.manipulation_functions
)
34 changes: 34 additions & 0 deletions libc/src/__support/math/frexpf16.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
//===-- Implementation header for frexpf16 ----------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H

#include "include/llvm-libc-macros/float16-macros.h"

#ifdef LIBC_TYPES_HAS_FLOAT16

#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"

namespace LIBC_NAMESPACE_DECL {

namespace math {

static constexpr float16 frexpf16(float16 x, int *exp) {
return fputil::frexp(x, *exp);
}

} // namespace math

} // namespace LIBC_NAMESPACE_DECL

#endif // LIBC_TYPES_HAS_FLOAT16

#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF16_H
3 changes: 1 addition & 2 deletions libc/src/math/generic/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1764,8 +1764,7 @@ add_entrypoint_object(
HDRS
../frexpf16.h
DEPENDS
libc.src.__support.macros.properties.types
libc.src.__support.FPUtil.manipulation_functions
libc.src.__support.math.frexpf16
)

add_entrypoint_object(
Expand Down
7 changes: 3 additions & 4 deletions libc/src/math/generic/frexpf16.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@
//===----------------------------------------------------------------------===//

#include "src/math/frexpf16.h"
#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"

#include "src/__support/math/frexpf16.h"

namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(float16, frexpf16, (float16 x, int *exp)) {
return fputil::frexp(x, *exp);
return math::frexpf16(x, exp);
}

} // namespace LIBC_NAMESPACE_DECL
18 changes: 17 additions & 1 deletion utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2158,6 +2158,17 @@ libc_support_library(
],
)

libc_support_library(
name = "__support_math_frexpf16",
hdrs = ["src/__support/math/frexpf16.h"],
deps = [
":__support_macros_config",
":__support_macros_properties_types",
":__support_fputil_manipulation_functions",
":llvm_libc_macros_float16_macros"
],
)

############################### complex targets ################################

libc_function(
Expand Down Expand Up @@ -3216,7 +3227,12 @@ libc_math_function(
]
)

libc_math_function(name = "frexpf16")
libc_math_function(
name = "frexpf16",
additional_deps = [
":__support_math_frexpf16"
],
)

libc_math_function(name = "fromfp")

Expand Down
Loading