Skip to content

[Clang] [Docs] Add release notes for #143514 and #143520 #147562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

Sirraide
Copy link
Member

@Sirraide Sirraide commented Jul 8, 2025

I forgot to include a release note in #143520, and it also ocurred to me that while #143514 is technically a bugfix in LLVM/Support, I think we should have one for it as well.

@Sirraide Sirraide requested a review from AaronBallman July 8, 2025 16:38
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jul 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 8, 2025

@llvm/pr-subscribers-clang

Author: None (Sirraide)

Changes

I forgot to include a release note in #143520, and it also ocurred to me that while #143514 is technically a bugfix in LLVM/Support, I think we should have one for it as well.


Full diff: https://github.com/llvm/llvm-project/pull/147562.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+6)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 712229cd11565..a919f3a71c9cf 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -678,6 +678,12 @@ Improvements to Clang's diagnostics
 - Clang now accepts ``@tparam`` comments on variable template partial
   specializations. (#GH144775)
 
+- Fixed a bug that caused diagnostic line wrapping to not function correctly on
+  some systems. (#GH139499)
+
+- Clang now tries to avoid printing file paths that contain ``..``, instead preferring
+  the canonical file path if it ends up being shorter.
+
 Improvements to Clang's time-trace
 ----------------------------------
 

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- Fixed a bug that caused diagnostic line wrapping to not function correctly on
some systems. (#GH139499)

- Clang now tries to avoid printing file paths that contain ``..``, instead preferring
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also handle things like . don't we? I suppose that doesn't matter for the release note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the simplification only kicks in if the path actually contains .. because while ../../../ etc is pretty common, I’m hoping no-one is writing ./././...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ./ doesn’t really affect the path length too much: if a path contains ./, simplifying it is just a matter of removing that segment, whereas with ../, we also remove the preceding segment, which might be quite long (e.g. x86_64-redhat-linux in the case of libstdc++).

@Sirraide Sirraide merged commit eb2b63c into llvm:main Jul 8, 2025
10 checks passed
@Sirraide Sirraide deleted the diags-release-notes branch July 8, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants