[llvm] Don't preserve analysis results after EmbedBitcodePass #146118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expensive checks complains when we mark them as preserved. The bitcode being embedded generally doesn't change anything important in the module, but some things are modified under ThinLTO, like vtables under WPD. This became a non-issue when we cloned the module, but after we had to revert that in #145987, we need to handle this case properly.
|
@llvm/pr-subscribers-llvm-transforms Author: Paul Kirth (ilovepi) ChangesExpensive checks complains when we mark them as preserved. The bitcode Full diff: https://github.com/llvm/llvm-project/pull/146118.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp b/llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp
index 73f567734a91b..f02256f8a83b9 100644
--- a/llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp
+++ b/llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp
@@ -41,5 +41,5 @@ PreservedAnalyses EmbedBitcodePass::run(Module &M, ModuleAnalysisManager &AM) {
embedBufferInModule(M, MemoryBufferRef(Data, "ModuleData"), ".llvm.lto");
- return PreservedAnalyses::all();
+ return PreservedAnalyses::none();
}
|
ilovepi
commented
Jun 27, 2025
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
…46118) Expensive checks complains when we mark them as preserved. The bitcode being embedded generally doesn't change anything important in the module, but some things are modified under ThinLTO, like vtables under WPD. This became a non-issue when we cloned the module, but after we had to revert that in llvm#145987, we need to handle this case properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expensive checks complains when we mark them as preserved. The bitcode
being embedded generally doesn't change anything important in the
module, but some things are modified under ThinLTO, like vtables under
WPD. This became a non-issue when we cloned the module, but after we had
to revert that in #145987, we need to handle this case properly.