[sanitizer_common] Drop support for Android 5

[brad0]

No description provided.

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Brad Smith (brad0)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/145227.diff

1 Files Affected:

• (modified) compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp (+3-30)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp
index 3bf9f8b316d36..653872c9848a5 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp
@@ -782,42 +782,15 @@ static int dl_iterate_phdr_cb(dl_phdr_info *info, size_t size, void *arg) {
   return 0;
 }
 
-static bool requiresProcmaps() {
-#  if SANITIZER_ANDROID && __ANDROID_API__ <= 22
-  // Fall back to /proc/maps if dl_iterate_phdr is unavailable or broken.
-  // The runtime check allows the same library to work with
-  // both K and L (and future) Android releases.
-  return AndroidGetApiLevel() <= ANDROID_LOLLIPOP_MR1;
-#  else
-  return false;
-#  endif
-}
-
-static void procmapsInit(InternalMmapVectorNoCtor<LoadedModule> *modules) {
-  MemoryMappingLayout memory_mapping(/*cache_enabled*/ true);
-  memory_mapping.DumpListOfModules(modules);
-}
-
 void ListOfModules::init() {
   clearOrInit();
-  if (requiresProcmaps()) {
-    procmapsInit(&modules_);
-  } else {
-    DlIteratePhdrData data = {&modules_, true};
-    dl_iterate_phdr(dl_iterate_phdr_cb, &data);
-  }
+  DlIteratePhdrData data = {&modules_, true};
+  dl_iterate_phdr(dl_iterate_phdr_cb, &data);
 }
 
 // When a custom loader is used, dl_iterate_phdr may not contain the full
 // list of modules. Allow callers to fall back to using procmaps.
-void ListOfModules::fallbackInit() {
-  if (!requiresProcmaps()) {
-    clearOrInit();
-    procmapsInit(&modules_);
-  } else {
-    clear();
-  }
-}
+void ListOfModules::fallbackInit() { clear(); }
 
 // getrusage does not give us the current RSS, only the max RSS.
 // Still, this is better than nothing if /proc/self/statm is not available

[enh-google]

@emrekultursay @DanAlbert fyi

(it probably doesn't matter much in practice -- not least because devices this old are likely to be 32-bit, and arm32 debugging is pretty comprehensively broken already -- but note that this is slightly ahead of us... we're still working on moving to api 22 [or, more likely 23] as our minimium.)

[brad0]

@emrekultursay @DanAlbert fyi

(it probably doesn't matter much in practice -- not least because devices this old are likely to be 32-bit, and arm32 debugging is pretty comprehensively broken already -- but note that this is slightly ahead of us... we're still working on moving to api 22 [or, more likely 23] as our minimium.)

What is the usual path for removing support altogether? As far as I can find the Play Store and Play Services have not supported 5.x for a year now.

[enh-google]

@emrekultursay @DanAlbert fyi
(it probably doesn't matter much in practice -- not least because devices this old are likely to be 32-bit, and arm32 debugging is pretty comprehensively broken already -- but note that this is slightly ahead of us... we're still working on moving to api 22 [or, more likely 23] as our minimium.)

What is the usual path for removing support altogether? As far as I can find the Play Store and Play Services have not supported 5.x for a year now.

i think you mean "a few months" ... it changed from 21 to 23 in February of this year :-)

https://developers.google.com/admob/android/migration#the_minimum_android_api_level_is_23

unfortunately the NDK hasn't caught up yet (that's why i tagged danalbert) and i actually don't know what the Studio policy on such things is (which is why i tagged emrekultursay).

[brad0]

i think you mean "a few months" ... it changed from 21 to 23 in February of this year :-)

https://developers.google.com/admob/android/migration#the_minimum_android_api_level_is_23

unfortunately the NDK hasn't caught up yet (that's why i tagged danalbert) and i actually don't know what the Studio policy on such things is (which is why i tagged emrekultursay).

Everything I came across, so far, said March 2024 (Play Store) and July 2024 (Play Services).

[enh-google]

i think you mean "a few months" ... it changed from 21 to 23 in February of this year :-)
https://developers.google.com/admob/android/migration#the_minimum_android_api_level_is_23
unfortunately the NDK hasn't caught up yet (that's why i tagged danalbert) and i actually don't know what the Studio policy on such things is (which is why i tagged emrekultursay).

Everything I came across, so far, said March 2024 (Play Store) and July 2024 (Play Services).

have you been listening to stochastic parrots by any chance?

https://developers.google.com/admob/android/rel-notes#24.0.0 seems quite clear that v24 was new this february (and seems likely to have been written by a human).