Skip to content

[lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out #143732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

[lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out #143732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab827f
[lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebugger…
DavidSpickett Jun 11, 2025
102139c
_exit
DavidSpickett Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
class TestMultipleSimultaneousDebuggers(TestBase):
NO_DEBUG_INFO_TESTCASE = True

# Sometimes times out on Linux, see https://github.com/llvm/llvm-project/issues/101162.
@skipIfLinux
@skipIfNoSBHeaders
@skipIfWindows
@skipIfHostIncompatibleWithTarget
Expand Down
7 changes: 5 additions & 2 deletions lldb/test/API/api/multiple-debuggers/multi-process-driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ int main (int argc, char **argv)
NUMBER_OF_SIMULTANEOUS_DEBUG_SESSIONS);
}

SBDebugger::Terminate();
exit (1);
// We do not call SBDebugger::Terminate() here because it will destroy
// data that might be being used by threads that are still running. Which
// would change the timeout into an unrelated crash.
// _exit instead of exit, to skip more things that could cause a crash.
_exit(1);
}
Loading