[Flang] Solved issue with inline compiler directive

[EbinJose2002]

Issue was with pointer passing.
Fixes #139297

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-flang-parser

Author: Ebin-McW (EbinJose2002)

Changes

Issue was with pointer passing.
Fixes #139297

---

Full diff: https://github.com/llvm/llvm-project/pull/143699.diff

1 Files Affected:

• (modified) flang/lib/Parser/prescan.cpp (+1-1)

diff --git a/flang/lib/Parser/prescan.cpp b/flang/lib/Parser/prescan.cpp
index 9aef0c9981e3c..2232b94b8da11 100644
--- a/flang/lib/Parser/prescan.cpp
+++ b/flang/lib/Parser/prescan.cpp
@@ -564,7 +564,7 @@ bool Prescanner::MustSkipToEndOfLine() const {
     return true; // skip over ignored columns in right margin (73:80)
   } else if (*at_ == '!' && !inCharLiteral_ &&
       (!inFixedForm_ || tabInCurrentLine_ || column_ != 6)) {
-    return !IsCompilerDirectiveSentinel(at_);
+    return !IsCompilerDirectiveSentinel(at_ + 1);
   } else {
     return false;
   }

[EbinJose2002]

ping

[Meinersbur]

ping.

Any progress on landing?

[Meinersbur]

@EbinJose2002 I can land this if you would like me to

[EbinJose2002]

@EbinJose2002 I can land this if you would like me to

Sure. Please go ahead with the landing. Thanks

[github-actions]

@EbinJose2002 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

[scamp-nvidia]

Hi - just pinging on this because I believe it's caused the issue I've highlighted in #165874 - whereby if there are two OpenMP pragmas in the same line, where 1 should be acting as a comment, instead of treating the second one as a comment, it treats it as an active, second OpenMP pragma that it needs to handle. We identified this in the source of an important application code that we test nightly and Flang has handled perfectly fine up until now.